Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table insert column w/ span support #4074

Merged
merged 2 commits into from
Mar 11, 2023
Merged

Table insert column w/ span support #4074

merged 2 commits into from
Mar 11, 2023

Conversation

zurfyx
Copy link
Member

@zurfyx zurfyx commented Mar 9, 2023

Same as #4063 but with columns

Screen.Recording.2023-03-09.at.9.53.15.AM.mov

(I'll look into headers separately)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 9, 2023
@vercel
Copy link

vercel bot commented Mar 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
lexical ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 11, 2023 at 1:27AM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 11, 2023 at 1:27AM (UTC)

@vercel
Copy link

vercel bot commented Mar 9, 2023

Deployment failed with the following error:

Was unable to schedule a deployment.

@zurfyx zurfyx changed the base branch from insert-row to main March 10, 2023 22:15
@github-actions
Copy link

github-actions bot commented Mar 11, 2023 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.85 KB (0%) 538 ms (0%) 355 ms (+24.55% 🔺) 892 ms
packages/lexical-rich-text/dist/LexicalRichText.js 37.68 KB (0%) 754 ms (0%) 332 ms (-17.95% 🔽) 1.1 s
packages/lexical-plain-text/dist/LexicalPlainText.js 37.65 KB (0%) 754 ms (0%) 425 ms (+52.04% 🔺) 1.2 s

@zurfyx zurfyx merged commit 52a7253 into main Mar 11, 2023
@zurfyx zurfyx mentioned this pull request Mar 24, 2023
Merged
@fantactuka fantactuka deleted the insert-column branch July 6, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerjbainbridge tylerjbainbridge tylerjbainbridge approved these changes

@trueadm trueadm Awaiting requested review from trueadm

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zurfyx @tylerjbainbridge @facebook-github-bot