Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim table e2e assert #4060

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Trim table e2e assert #4060

merged 2 commits into from
Mar 9, 2023

Conversation

zurfyx
Copy link
Member

@zurfyx zurfyx commented Mar 8, 2023

Ez PR, just trimming asserts. 5x5 tables assertions are very hard to read. None of the tests require such a long table to test the correct functioning. Trimmed most of them to 2x3

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 8, 2023
@vercel
Copy link

vercel bot commented Mar 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
lexical ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 9, 2023 at 1:45PM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 9, 2023 at 1:45PM (UTC)

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 26.72 KB (0%) 535 ms (0%) 178 ms (-59.35% 🔽) 712 ms
packages/lexical-rich-text/dist/LexicalRichText.js 37.46 KB (0%) 750 ms (0%) 438 ms (+47.84% 🔺) 1.2 s
packages/lexical-plain-text/dist/LexicalPlainText.js 37.43 KB (0%) 749 ms (0%) 563 ms (+94.82% 🔺) 1.4 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants