-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Chinese character support for native webkit #3846
Added Chinese character support for native webkit #3846
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi @asaAnnabelle! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
However, it looks like this is causing e2e tests to fail? |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
05bc2b2
to
98f5091
Compare
This will among other things add support for Chinese character on for native WebKit
a0bec6e
to
adc6215
Compare
Thank you! |
Native webkit doesn't add Safari version in the useragent string. This PR checks for the existence of webkit engine in that string. This fixes a varity of issues including autocompleting Chinese characters.
Before:
Chinese.character.before.mov
After:
Chinese.characters.work.mov