Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.8] Allow users to customise the indentation of tabs #3802

Merged
merged 2 commits into from
Feb 9, 2023
Merged

[0.8] Allow users to customise the indentation of tabs #3802

merged 2 commits into from
Feb 9, 2023

Conversation

thegreatercurve
Copy link
Contributor

@thegreatercurve thegreatercurve commented Jan 31, 2023 •
edited
Loading

Add ability to customise the indentation of tabs by specifying a CSS variable. This can any CSS unit that is accepted by calc.

Closes #3473

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 31, 2023
@vercel
Copy link

vercel bot commented Jan 31, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
lexical ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 31, 2023 at 5:51PM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 31, 2023 at 5:51PM (UTC)

@github-actions
Copy link

github-actions bot commented Jan 31, 2023 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 25.43 KB (+0.37% 🔺) 509 ms (+0.37% 🔺) 368 ms (+70.84% 🔺) 877 ms
packages/lexical-rich-text/dist/LexicalRichText.js 39.34 KB (+0.21% 🔺) 787 ms (+0.21% 🔺) 290 ms (-48.16% 🔽) 1.1 s
packages/lexical-plain-text/dist/LexicalPlainText.js 39.31 KB (+0.21% 🔺) 787 ms (+0.21% 🔺) 333 ms (-10.2% 🔽) 1.2 s

@thegreatercurve thegreatercurve marked this pull request as ready for review January 31, 2023 17:14
@thegreatercurve thegreatercurve force-pushed the feat/customistable-indentations branch from 87c769e to 15b26f4 Compare January 31, 2023 17:48
trueadm
trueadm approved these changes Jan 31, 2023
View reviewed changes
Copy link
Collaborator

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 0.8

@trueadm trueadm changed the title Allow users to customise the indentation of tabs [0.8] Allow users to customise the indentation of tabs Jan 31, 2023
@trueadm trueadm merged commit 3986743 into main Feb 9, 2023
@trueadm trueadm deleted the feat/customistable-indentations branch February 9, 2023 12:38
@thegreatercurve thegreatercurve mentioned this pull request Feb 9, 2023
Merged
@GermanJablo GermanJablo mentioned this pull request Mar 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trueadm trueadm trueadm approved these changes

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Unable to customize indentation value
3 participants
@thegreatercurve @trueadm @facebook-github-bot