Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lexical-playground): fix bugs related to ComponentPickerPlugin #3787

Merged
merged 2 commits into from
Jan 30, 2023
Merged

fix(lexical-playground): fix bugs related to ComponentPickerPlugin #3787

merged 2 commits into from
Jan 30, 2023

Conversation

smzst
Copy link
Contributor

@smzst smzst commented Jan 27, 2023

I have made the following two fixes:

  1. 70eed93: When the ComponentPicker options are opened at a position overlapping the table, strings in the cell overlap and become difficult to read.
    • Intention: Another idea I had was to increase the z-index of the ComponentPicker options, but it doesn't feel right that only the table cells are floating, so I modified it as shown in PR.
  2. d67b602: Missing Table (Experimental) in ComponentPicker options (maybe not a bug).
Before/After

Before

before-bug-related-component-picker-plugin

After

after-bug-related-component-picker-plugin

@vercel
Copy link

vercel bot commented Jan 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
lexical ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 27, 2023 at 4:43PM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 27, 2023 at 4:43PM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 27, 2023
@smzst smzst force-pushed the bug/related-component-picker-plugin branch from d67b602 to 42dd114 Compare January 27, 2023 16:42
@smzst smzst marked this pull request as draft January 27, 2023 18:38
@smzst smzst marked this pull request as ready for review January 29, 2023 05:24
@smzst
Copy link
Contributor Author

smzst commented Jan 29, 2023

E2E test CI is failing, but I don't think it's due to this fix, so I'm making it ready for review.
I think it's the same problem as #3769 (comment).

zurfyx
zurfyx approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@zurfyx zurfyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't repro the overlapping bug before and after, but overall the fix LGTM, thank you for adding the experimental tables onto the list

cc @tylerjbainbridge

tylerjbainbridge
tylerjbainbridge approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@tylerjbainbridge tylerjbainbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why those position/zindex styles were on the Experimental Table Component in the first place, maybe @trueadm has insights.

Looks good to me though!

@zurfyx zurfyx merged commit c0c37b6 into facebook:main Jan 30, 2023
@trueadm trueadm mentioned this pull request Feb 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerjbainbridge tylerjbainbridge tylerjbainbridge approved these changes

@zurfyx zurfyx zurfyx approved these changes

@trueadm trueadm Awaiting requested review from trueadm

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@smzst @zurfyx @tylerjbainbridge @facebook-github-bot