Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lexical-playground): NewTablePlugin is not draggable #3747

Merged

Conversation

smzst
Copy link
Contributor

@smzst smzst commented Jan 18, 2023

The Lexical Playground environment has two components, Table and Table (Experimental), the former draggable but not the latter.
I thought it would be desirable to have a component that is draggable like the Table component, so I fixed this as a bug.

Before/After

Before:
before-newtableplugin-is-not-draggable

After:
after-newtableplugin-is-not-draggable

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 18, 2023
@vercel
Copy link

vercel bot commented Jan 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
lexical ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 18, 2023 at 0:36AM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 18, 2023 at 0:36AM (UTC)

Copy link
Contributor

@thegreatercurve thegreatercurve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@thegreatercurve thegreatercurve merged commit 391f145 into facebook:main Jan 19, 2023
@trueadm trueadm mentioned this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants