Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in reconciler sub-tree text content cache #3669

Merged
merged 4 commits into from
Jan 3, 2023
Merged

Fix bug in reconciler sub-tree text content cache #3669

merged 4 commits into from
Jan 3, 2023

Conversation

trueadm
Copy link
Collaborator

@trueadm trueadm commented Jan 3, 2023

Fixes #3602.

I think a bit of logic was missed from #1993. It's hard to fully know though. Would be good to have the eyes of @zurfyx on this.

@vercel
Copy link

vercel bot commented Jan 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
lexical ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 3, 2023 at 2:20PM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 3, 2023 at 2:20PM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 3, 2023
@github-actions
Copy link

github-actions bot commented Jan 3, 2023 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 25.25 KB (+0.02% 🔺) 505 ms (+0.02% 🔺) 146 ms (+153.22% 🔺) 651 ms
packages/lexical-rich-text/dist/LexicalRichText.js 39.07 KB (+0.02% 🔺) 782 ms (+0.02% 🔺) 116 ms (-28.78% 🔽) 897 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 39.04 KB (+0.02% 🔺) 781 ms (+0.02% 🔺) 75 ms (-5.46% 🔽) 856 ms

@trueadm trueadm merged commit 4dae4fb into main Jan 3, 2023
@trueadm trueadm deleted the fix-text-content-bug branch January 3, 2023 14:46
@trueadm trueadm mentioned this pull request Jan 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acywatson acywatson acywatson left review comments

@zurfyx zurfyx zurfyx approved these changes

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Odd behaviour with $getRoot().getTextContent() when copying and pasting it is stripping new lines.
4 participants
@trueadm @zurfyx @acywatson @facebook-github-bot