Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.8] Update ContentEditable types #3580

Merged
merged 3 commits into from
Feb 9, 2023
Merged

[0.8] Update ContentEditable types #3580

merged 3 commits into from
Feb 9, 2023

Conversation

thegreatercurve
Copy link
Contributor

@thegreatercurve thegreatercurve commented Dec 17, 2022 •
edited
Loading

The @ts-ignore amongst the ContentEditable props was masking for incorrect type issues.

Tested Flow types internally to validate that they work correctly.

Closes #3550
Closes #3658

@vercel
Copy link

vercel bot commented Dec 17, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
lexical ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 9, 2023 at 0:52AM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 9, 2023 at 0:52AM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 17, 2022
@thegreatercurve thegreatercurve changed the title Add TS and Flow types Update ContentEditable types Dec 17, 2022
@thegreatercurve thegreatercurve marked this pull request as ready for review December 17, 2022 20:30
@thegreatercurve thegreatercurve changed the title Update ContentEditable types [0.8] Update ContentEditable types Dec 17, 2022
acywatson
acywatson approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@acywatson acywatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right - thanks!

@thegreatercurve thegreatercurve force-pushed the feat/improve-content-editable-type branch from 346d182 to cfbde70 Compare January 1, 2023 15:57
@github-actions
Copy link

github-actions bot commented Jan 1, 2023 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/lexical/dist/Lexical.js 25.83 KB (0%) 517 ms (0%) 100 ms (+64.39% 🔺) 616 ms
packages/lexical-rich-text/dist/LexicalRichText.js 36.46 KB (0%) 730 ms (0%) 98 ms (+5.16% 🔺) 828 ms
packages/lexical-plain-text/dist/LexicalPlainText.js 36.43 KB (0%) 729 ms (0%) 47 ms (-60.57% 🔽) 775 ms

@thegreatercurve thegreatercurve force-pushed the feat/improve-content-editable-type branch from cfbde70 to f34d2df Compare February 9, 2023 12:50
@thegreatercurve thegreatercurve merged commit 88133dc into main Feb 9, 2023
@thegreatercurve thegreatercurve deleted the feat/improve-content-editable-type branch February 9, 2023 13:06
@thegreatercurve thegreatercurve mentioned this pull request Feb 9, 2023
Merged
@zurfyx zurfyx mentioned this pull request Jun 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acywatson acywatson acywatson approved these changes

@trueadm trueadm Awaiting requested review from trueadm

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@fantactuka fantactuka Awaiting requested review from fantactuka fantactuka is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
3 participants
@thegreatercurve @acywatson @facebook-github-bot