Selection.extract fix #2620
Merged
Selection.extract fix #2620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acywatson
requested review from
trueadm,
zurfyx,
fantactuka,
tylerjbainbridge and
thegreatercurve
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
thegreatercurve
approved these changes
Jul 11, 2022
lateefazeez
pushed a commit
to lateefazeez/lexical
that referenced
this pull request
Jul 20, 2022
* Selection.extract sfix * fix tests
thegreatercurve
pushed a commit
that referenced
this pull request
Nov 25, 2022
* Selection.extract sfix * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there's some additional weirdness in Selection.extract around partial selection and text splitting (looking at the code, it seems not all the cases are covered), but I think this is more correct than before. Basically, if only a single node is selected and the selection is collapsed, we don't need to worry about splitting or anything - just return that node.
EDIT:
Changing the way extract works caused some tests to fail. Basically, I think this was a "load-bearing bug". There was some weird behavior around toggling links with collapsed Selections (it would usually make the one side of the text a link, which is not consistent with how other editors work). I fixed this by basically making toggling links on a collapsed selection do nothing. In the future, we could improve this by inserting a link at that spot, like GDocs and Quip do, but that behavior actually seems weird to me.
Fixes #2614