Use Vite server for E2E tests in CI (Fix windows CI failures) #2584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
acywatson
changed the title
acywatson
requested review from
trueadm,
zurfyx,
fantactuka,
tylerjbainbridge and
thegreatercurve
as code owners
thegreatercurve
approved these changes
Jul 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm pretty sure vercel/serve is leaking file descriptors: vercel/serve#575
This causes the Windows CI to fail when the node process exits because of the OS file limit being exceeded. The default file limit is apparently significantly lower on Windows that on Linux and macOS, which is why we saw the issue manifest there first.
I'd like to try to fix this issue there (for others' sake) but I think the best thing for us to do is just use the Vite static file server anyway.