Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverse MarkdownExport loop order to take TextMatchTransformers into account first #2582

Merged
merged 3 commits into from
Jul 5, 2022
Merged

Reverse MarkdownExport loop order to take TextMatchTransformers into account first #2582

merged 3 commits into from
Jul 5, 2022

Conversation

lukasjaronis
Copy link
Contributor

Issue was that TextMatchTransformers were being skipped completely for export. Reversing the order in the loop has fixed this problem. I did a quick test on my local machine and export method is being triggered successfully for TextNode's.

@facebook-github-bot
Copy link
Contributor

Hi @lukasjaronis!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@vercel
Copy link

vercel bot commented Jul 1, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lexical ✅ Ready (Inspect) Visit Preview Jul 5, 2022 at 0:04AM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview Jul 5, 2022 at 0:04AM (UTC)

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 2, 2022
@lukasjaronis lukasjaronis force-pushed the reverse-markdown-export-loop-order branch from 946d309 to 83e4a17 Compare July 4, 2022 23:59
@acywatson
Copy link
Contributor

Code seems fine to me - let's make sure @fantactuka is good and we can merge.

@acywatson
Copy link
Contributor

fixes #2576

@fantactuka fantactuka merged commit 1388004 into facebook:main Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantactuka fantactuka fantactuka approved these changes

@trueadm trueadm Awaiting requested review from trueadm

@zurfyx zurfyx Awaiting requested review from zurfyx zurfyx is a code owner

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukasjaronis @facebook-github-bot @acywatson @fantactuka