fix(lexical): Text with underline format is stripped out on paste #2555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
LuciNyan
force-pushed
the
fix-underline-format-is-stripped-out-on-paste
branch
from
6a8f7ff to
6268b42
Compare
LuciNyan
requested review from
trueadm,
zurfyx,
fantactuka,
acywatson,
tylerjbainbridge and
thegreatercurve
as code owners
zurfyx
approved these changes
Jun 29, 2022
Comment on lines
+852
to
+854
| if ($isTextNode(lexicalNode) && hasUnderlineTextDecoration) { | ||
| lexicalNode.toggleFormat('underline'); | ||
| } |
There was a problem hiding this comment.
Nit; mind adding an early return at the top, would be faster than reevaluating this 4 times
if (!$isTextNode(lexicalNode)) {
return;
}
|
Feel free to follow up on another PR, going to close 0.3.6 now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
function
convertSpanElementdoes not handletext-decoration: underlinecloses #2552
2022-06-29.2.25.20.mov