Migrate to TS strict mode 2/n #2469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
thegreatercurve
force-pushed
the
feature/ts-strict-mode-2
branch
from
380c2cd to
eddf329
Compare
thegreatercurve
changed the title
thegreatercurve
requested review from
trueadm,
zurfyx,
fantactuka,
acywatson and
tylerjbainbridge
as code owners
zurfyx
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing these as smaller PRs as some of these types fixes involve changing business logic. This PR reduces the number of TS errors from 300 to 129.
To test TS strict mode, enable the strict flag in
tsconfig.build.jsonand then runtsc -p tsconfig.build.json#2469