-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default value for undefined case in markdown transformers #2453
Add default value for undefined case in markdown transformers #2453
Conversation
Hi @imnoahcook! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Just needs the CLA signed, when you have a chance. |
Signed CLA ✔️ |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Ah, I forgot, we don't use nullish coalescing in Lexical for some reason that I can't quite recall at the moment. Something. about not wanting to set up the Babel plugin to transpile it, I think. You can use a logical OR, instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor update, looks good otherwise!
It looks like the playground vercel build is failing because of a missing script that was added recently. Rebasing might fix that. |
79ec375
to
074ead6
Compare
…com/imnoahcook/lexical into bug/markdown-transformers-undefined
Resolved changed by @fantactuka and rebased to pass tests. |
Easy review
Context:
I was playing with the rich text playground and noticed that if you only used the
ELEMENT_TRANFORMERS
from@lexical/markdown
, you will get a runtime error as it tries to iterate over the textFormat and textMatch fields, which are undefined in this case.They're undefined because none of the element transformers have these fields in them.
I consider this a bug, because there shouldn't be any reason someone not to be able to use
etc..
without using the rest of the markdown exports
Solution:
Add a default empty array value to
text-format
andtext-match