Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bad warnOnlyOnce minification #2448

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Fix bad warnOnlyOnce minification #2448

merged 1 commit into from
Jun 16, 2022

Conversation

zurfyx
Copy link
Member

@zurfyx zurfyx commented Jun 16, 2022

Minified to

exports.RichTextPlugin=function({contentEditable:a,placeholder:c,initialEditorState:f}){void 0!==f&&(void 0)();let [b]=e.useLexicalComposerContext(),g=t(b),d=u(b);w(b,f);return h.createElement(h.Fragment,null,a,g&&c,d)}

(void 0)() -> that's really bad

@vercel
Copy link

vercel bot commented Jun 16, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lexical ✅ Ready (Inspect) Visit Preview Jun 16, 2022 at 7:05PM (UTC)
lexical-playground ✅ Ready (Inspect) Visit Preview Jun 16, 2022 at 7:05PM (UTC)

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 16, 2022
@zurfyx zurfyx merged commit 841a651 into main Jun 16, 2022
@trueadm trueadm deleted the important-fix branch June 16, 2022 20:44
zurfyx added a commit that referenced this pull request Jun 17, 2022
@zurfyx
Revert "Fix bad warnOnlyOnce minification (#2448)"
7cd9220 
This reverts commit 841a651.
zurfyx added a commit that referenced this pull request Jun 17, 2022
@zurfyx
Revert "Revert "Fix bad warnOnlyOnce minification (#2448)""
d178162 
This reverts commit 8fbf19d50247e70491981d98edad4d0e24e43d57.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantactuka fantactuka fantactuka approved these changes

@trueadm trueadm Awaiting requested review from trueadm

@acywatson acywatson Awaiting requested review from acywatson acywatson is a code owner

@tylerjbainbridge tylerjbainbridge Awaiting requested review from tylerjbainbridge

@thegreatercurve thegreatercurve Awaiting requested review from thegreatercurve

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zurfyx @fantactuka @facebook-github-bot