Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Collab not connecting in dev mode #6640

Closed
etrepum opened this issue Sep 18, 2024 · 2 comments · Fixed by #6644
Closed

Bug: Collab not connecting in dev mode #6640

etrepum opened this issue Sep 18, 2024 · 2 comments · Fixed by #6644

Comments

@etrepum
Copy link
Collaborator

etrepum commented Sep 18, 2024

Lexical version: 0.17.1

Steps To Reproduce

From #6625 (comment)

  1. npm run start
  2. npm run test-e2e-chromium (from another terminal)

The current behavior

Fails because the websocket doesn't stay connected. I suspect this is a React strict mode related issue. CI doesn't test dev mode.

The expected behavior

Websocket stays connected

Impact of fix

I suspect that it would be pretty hard to work on collab right now with dev mode broken?
@etrepum
Copy link
Collaborator Author

etrepum commented Sep 18, 2024

Could be related to #6271

@etrepum
Copy link
Collaborator Author

etrepum commented Sep 18, 2024

Also related #6619

etrepum added a commit to etrepum/lexical that referenced this issue Sep 19, 2024
@etrepum
Fix facebook#6640 by reverting to disconnect timing from before faceb…
f43f344 
…ook#6619 for sync provider.connect
@etrepum etrepum mentioned this issue Sep 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@etrepum