add canMergeWhenEmpty

facebook · Jul 17, 2024 · 8e97547 · 8e97547
1 parent 8d078bb
commit 8e97547
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 2 deletions.
diff --git a/packages/lexical-list/src/LexicalListItemNode.ts b/packages/lexical-list/src/LexicalListItemNode.ts
@@ -404,6 +404,10 @@ export class ListItemNode extends ElementNode {
   createParentElementNode(): ElementNode {
     return $createListNode('bullet');
   }
+
+  canMergeWhenEmpty(): true {
+    return true;
+  }
 }
 
 function $setListItemThemeClassNames(

diff --git a/packages/lexical-rich-text/src/index.ts b/packages/lexical-rich-text/src/index.ts
@@ -202,6 +202,10 @@ export class QuoteNode extends ElementNode {
     this.replace(paragraph);
     return true;
   }
+
+  canMergeWhenEmpty(): true {
+    return true;
+  }
 }
 
 export function $createQuoteNode(): QuoteNode {

diff --git a/packages/lexical/src/LexicalSelection.ts b/packages/lexical/src/LexicalSelection.ts
@@ -1257,13 +1257,12 @@ export class RangeSelection implements BaseSelection {
     const blocks = blocksParent.getChildren();
     const isLI = (node: LexicalNode) =>
       '__value' in node && '__checked' in node;
-    const isQuote = (node: LexicalNode) => node.__type === 'quote';
     const isMergeable = (node: LexicalNode): node is ElementNode =>
       $isElementNode(node) &&
       INTERNAL_$isBlock(node) &&
       !node.isEmpty() &&
       $isElementNode(firstBlock) &&
-      (!firstBlock.isEmpty() || isLI(firstBlock) || isQuote(firstBlock));
+      (!firstBlock.isEmpty() || firstBlock.canMergeWhenEmpty());
 
     const shouldInsert = !$isElementNode(firstBlock) || !firstBlock.isEmpty();
     const insertedParagraph = shouldInsert ? this.insertParagraph() : null;

diff --git a/packages/lexical/src/nodes/LexicalElementNode.ts b/packages/lexical/src/nodes/LexicalElementNode.ts
@@ -563,6 +563,10 @@ export class ElementNode extends LexicalNode {
   ): boolean {
     return false;
   }
+
+  canMergeWhenEmpty(): boolean {
+    return false;
+  }
 }
 
 export function $isElementNode(