Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of .gitignore files. #306

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Improve handling of .gitignore files. #306

merged 1 commit into from
Mar 6, 2019

Conversation

amanda-mitchell
Copy link
Contributor

I tried to use jscodeshift in a repo that had a .gitignore that used \r\n as the newline character, and it crashed inside of snapdragon (used by minimatch) because all of the file globs had trailing \rs.

This PR cleans up trailing \rs and also prevents .gitignore comments from being treated as globs.

* Omit comments from list of patterns.
* Support .gitignore files with \r\n linebreaks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants