igl | shell | Introduce different screen modes

Summary: Introduced different screen modes for shell apps. Reviewed By: mmaurer Differential Revision: D62977516 fbshipit-source-id: 863b3f89be45854cc0bdaef23bbf573c791b747d
facebook · Sep 19, 2024 · 8f305c6 · 8f305c6
1 parent 8d9de28
commit 8f305c6
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 7 deletions.
diff --git a/shell/shared/renderSession/RenderSessionConfig.h b/shell/shared/renderSession/RenderSessionConfig.h
@@ -12,13 +12,19 @@
 
 namespace igl::shell {
 
+enum class ScreenMode {
+  Windowed,
+  FullscreenNoTaskbar,
+  Fullscreen,
+};
+
 struct RenderSessionConfig {
   std::string displayName;
   BackendVersion backendVersion;
   igl::TextureFormat colorFramebufferFormat = igl::TextureFormat::BGRA_UNorm8;
   uint32_t width = 1024;
   uint32_t height = 768;
-  bool fullscreen = false;
+  ScreenMode screenMode = ScreenMode::Windowed;
 };
 
 } // namespace igl::shell
diff --git a/shell/windows/opengl/App.cpp b/shell/windows/opengl/App.cpp
@@ -146,7 +146,7 @@ GLFWwindow* initGLWindow(const shell::RenderSessionConfig& config) {
   glfwWindowHint(GLFW_DOUBLEBUFFER, true);
   glfwWindowHint(GLFW_RESIZABLE, true);
   glfwWindowHint(GLFW_SRGB_CAPABLE, true);
-  glfwWindowHint(GLFW_MAXIMIZED, config.fullscreen);
+  glfwWindowHint(GLFW_MAXIMIZED, config.screenMode != shell::ScreenMode::Windowed);
 
   GLFWwindow* windowHandle =
       glfwCreateWindow(config.width, config.height, config.displayName.c_str(), NULL, NULL);
@@ -285,7 +285,7 @@ int main(int argc, char* argv[]) {
           .colorFramebufferFormat = TextureFormat::RGBA_SRGB,
           .width = 1024,
           .height = 768,
-          .fullscreen = false,
+          .screenMode = shell::ScreenMode::Windowed,
       },
   };
 

diff --git a/shell/windows/opengles/App.cpp b/shell/windows/opengles/App.cpp
@@ -106,7 +106,7 @@ GLFWwindow* initGLESWindow(const shell::RenderSessionConfig& config) {
   glfwWindowHint(GLFW_DOUBLEBUFFER, true);
   glfwWindowHint(GLFW_RESIZABLE, true);
   glfwWindowHint(GLFW_SRGB_CAPABLE, true);
-  glfwWindowHint(GLFW_MAXIMIZED, config.fullscreen);
+  glfwWindowHint(GLFW_MAXIMIZED, config.screenMode != shell::ScreenMode::Windowed);
 
   GLFWwindow* windowHandle =
       glfwCreateWindow(config.width, config.height, config.displayName.c_str(), NULL, NULL);
@@ -192,7 +192,7 @@ int main(int argc, char* argv[]) {
           .colorFramebufferFormat = TextureFormat::RGBA_UNorm8,
           .width = 1024,
           .height = 768,
-          .fullscreen = false,
+          .screenMode = shell::ScreenMode::Windowed,
       },
   };
 

diff --git a/shell/windows/vulkan/App.cpp b/shell/windows/vulkan/App.cpp
@@ -83,7 +83,7 @@ GLFWwindow* initWindow(const shell::RenderSessionConfig& config) {
   glfwWindowHint(GLFW_CLIENT_API, GLFW_NO_API);
   glfwWindowHint(GLFW_RESIZABLE, GLFW_FALSE);
   glfwWindowHint(GLFW_SRGB_CAPABLE, GLFW_TRUE);
-  glfwWindowHint(GLFW_MAXIMIZED, config.fullscreen);
+  glfwWindowHint(GLFW_MAXIMIZED, config.screenMode != shell::ScreenMode::Windowed);
 
   GLFWwindow* windowHandle =
       glfwCreateWindow(config.width, config.height, config.displayName.c_str(), nullptr, nullptr);
@@ -207,7 +207,7 @@ int main(int argc, char* argv[]) {
           .colorFramebufferFormat = TextureFormat::BGRA_UNorm8,
           .width = 1024,
           .height = 768,
-          .fullscreen = false,
+          .screenMode = shell::ScreenMode::Windowed,
       },
   };