ShaderUniforms: Set isSubAllocated once

Summary: Only set it once. Reviewed By: EricGriffith Differential Revision: D47780941 fbshipit-source-id: 4c2acfc88ee1e84f24ee021f6f6885bbdf2f8698
facebook · Jul 26, 2023 · 42d4861 · 42d4861
1 parent b3729a0
commit 42d4861
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/IGLU/simple_renderer/ShaderUniforms.cpp b/IGLU/simple_renderer/ShaderUniforms.cpp
@@ -61,9 +61,8 @@ ShaderUniforms::ShaderUniforms(igl::IDevice& device,
   size_t uniformBufferLimit = 0;
   device.getFeatureLimits(igl::DeviceFeatureLimits::MaxUniformBufferBytes, uniformBufferLimit);
 
+  const bool isSuballocated = _backend == igl::BackendType::Vulkan;
   for (const igl::BufferArgDesc& iglDesc : reflection.allUniformBuffers()) {
-    bool isSuballocated = (_backend == igl::BackendType::Vulkan) ? true : false;
-
     size_t length = iglDesc.bufferDataSize;
     IGL_ASSERT_MSG(length > 0, "unexpected buffer with size 0");
     IGL_ASSERT_MSG(length <= MAX_SUBALLOCATED_BUFFER_SIZE_BYTES &&