Added valid check for FP32 sampled attachment

Summary: fp32 sampling is supported starting from certain MacOs and iOS versions as part of device capabilities. Differential Revision: D47618906 fbshipit-source-id: 9f7c347730bbfbf96a573bcbc7d509c43dbfa0a1
facebook · Jul 20, 2023 · 2519a06 · 2519a06
1 parent 950a600
commit 2519a06
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/igl/metal/DeviceFeatureSet.h b/src/igl/metal/DeviceFeatureSet.h
@@ -49,6 +49,7 @@ class DeviceFeatureSet final {
   DeviceFeatureDesc deviceFeatureDesc_;
   size_t maxMultisampleCount_;
   size_t maxBufferLength_;
+  bool supports32BitFloatFiltering_ = false;
 };
 
 } // namespace metal

diff --git a/src/igl/metal/DeviceFeatureSet.mm b/src/igl/metal/DeviceFeatureSet.mm
@@ -94,6 +94,11 @@
 
   // get max buffer length
   maxBufferLength_ = [device maxBufferLength];
+
+  if (@available(macOS 11.0, iOS 14.0, *)) {
+    // this API became available as of iOS 14 and macOS 11
+    supports32BitFloatFiltering_ = device.supports32BitFloatFiltering;
+  }
 }
 
 bool DeviceFeatureSet::hasFeature(DeviceFeatures feature) const {
@@ -342,7 +347,8 @@
   case TextureFormat::RGBA_UInt32:
     return sampled | storage | attachment | sampledAttachment;
   case TextureFormat::RGBA_F32:
-    return sampled | storage | attachment | sampledAttachment;
+    return sampled | storage | attachment | sampledAttachment |
+           (supports32BitFloatFiltering_ ? sampledFiltered : 0);
     // Compressed formats
 
   case TextureFormat::RGBA_ASTC_4x4: