Upgraded guzzle4 to 4.1.6 in the framework tests #3368
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been imported into Phabricator, and discussion and review of the diff will take place at https://reviews.facebook.net/D21087 |
|
Hilariously phabricator allows |
|
I'll remember that for the future. :) |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 5, 2025
Summary: X-link: meta-pytorch/monarch#1114 ``` VULNERABILITY RUSTSEC-2025-0055 - 2025-08-29: Logging user input may result in poisoning logs with ANSI escape sequences Package: tracing-subscriber 0.3.19 Previous versions of tracing-subscriber were vulnerable to ANSI escape sequence injection attacks. Untrusted user input containing ANSI escape sequences could be injected into terminal output when logged, potentially allowing attackers to: - Manipulate terminal title bars - Clear screens or modify terminal display - Potentially mislead users through terminal manipulation In isolation, impact is minimal, however security issues have been found in terminal emulators that enabled an attacker to use ANSI escape sequences via logs to exploit vulnerabilities in the terminal emulator. This was patched in [PR #3368](tokio-rs/tracing#3368) to escape ANSI control characters from user input. ``` Reviewed By: dtolnay Differential Revision: D81802144 fbshipit-source-id: 1430805e74df708af6cb7580eb1b0a2a58b14ac2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The passed tests changes from
93.01%to92.54%.Old stats:
New stats:
You can see the old and new error logs here: https://gist.github.com/GrahamCampbell/826d87c35e3049f683dc.