Remove extra semi colon from proxygen/lib/dns/CAresResolver.cpp

Summary: `-Wextra-semi` or `-Wextra-semi-stmt` If the code compiles, this is safe to land. Reviewed By: palmje Differential Revision: D51995045 fbshipit-source-id: e5befec100356983e08795ad0b6768edf09926c3
facebook · Dec 12, 2023 · b0a378e · b0a378e
1 parent 00b58ba
commit b0a378e
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 7 deletions.
diff --git a/third-party/proxygen/src/proxygen/lib/dns/CAresResolver.cpp b/third-party/proxygen/src/proxygen/lib/dns/CAresResolver.cpp
@@ -58,10 +58,13 @@ class NullStatsCollector : public DNSResolver::StatsCollector {
   ~NullStatsCollector() override {
   }
   void recordSuccess(const std::vector<DNSResolver::Answer>& /*answers*/,
-                     std::chrono::milliseconds /*latency*/) noexcept override{};
+                     std::chrono::milliseconds /*latency*/) noexcept override {
+  }
   void recordError(const folly::exception_wrapper& /*ew*/,
-                   std::chrono::milliseconds /*latency*/) noexcept override{};
-  void recordQueryResult(uint8_t /*rcode*/) noexcept override{};
+                   std::chrono::milliseconds /*latency*/) noexcept override {
+  }
+  void recordQueryResult(uint8_t /*rcode*/) noexcept override {
+  }
 };
 
 NullStatsCollector nullStatsCollector;

diff --git a/third-party/proxygen/src/proxygen/lib/dns/DNSResolver.cpp b/third-party/proxygen/src/proxygen/lib/dns/DNSResolver.cpp
@@ -116,7 +116,8 @@ std::string DNSResolver::getPtrName(const SocketAddress& address) {
 
 void DNSResolver::resolveMailExchange(ResolutionCallback* /*cb*/,
                                       const std::string& /*domain*/,
-                                      std::chrono::milliseconds /*timeout*/){};
+                                      std::chrono::milliseconds /*timeout*/) {
+}
 
 std::string describe(const DNSResolver::ResolutionStatus status, bool details) {
 #define DNSRESOLVER_RESOLUTION_STATUS_STR(sym, descr) #sym,

diff --git a/third-party/proxygen/src/proxygen/lib/http/connpool/Endpoint.h b/third-party/proxygen/src/proxygen/lib/http/connpool/Endpoint.h
@@ -26,7 +26,8 @@ class Endpoint {
   }
 
   explicit Endpoint(const folly::SocketAddress& addr, bool isSecure)
-      : Endpoint(addr.getAddressStr(), addr.getPort(), isSecure){};
+      : Endpoint(addr.getAddressStr(), addr.getPort(), isSecure) {
+  }
 
   const std::string& getHostname() const {
     return hostname_;

diff --git a/third-party/proxygen/src/proxygen/lib/http/connpool/SessionHolder.cpp b/third-party/proxygen/src/proxygen/lib/http/connpool/SessionHolder.cpp
@@ -270,13 +270,13 @@ void SessionHolder::onPingReplySent(int64_t latency) {
   if (originalSessionInfoCb_) {
     originalSessionInfoCb_->onPingReplySent(latency);
   }
-};
+}
 
 void SessionHolder::onPingReplyReceived() {
   if (originalSessionInfoCb_) {
     originalSessionInfoCb_->onPingReplyReceived();
   }
-};
+}
 
 void SessionHolder::onSettingsOutgoingStreamsFull(
     const HTTPSessionBase& session) {