Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[apple][v0.8] Define the deployment target in the frameworks metadata #425

Conversation

alloy
Copy link
Contributor

@alloy alloy commented Dec 4, 2020

Fixes #420

Summary

Apple App Store submission, at least the iOS one, requires this metadata to be specified when only targeting a subset of possible archs.

Test Plan

(Taken from #428)

~/tmp » curl -L -O https://12725-154201259-gh.circle-artifacts.com/0/tmp/hermes/output/hermes-engine-darwin-v0.7.1.tgz
~/tmp » tar -zvxf hermes-engine-darwin-v0.7.1.tgz
~/tmp » cd package/
~/t/package » node unpack-tarball.js
~/t/package » /usr/libexec/PlistBuddy -c 'Print :MinimumOSVersion' destroot/Library/Frameworks/iphoneos/hermes.framework/Info.plist
10.0
~/t/package » /usr/libexec/PlistBuddy -c 'Print :LSMinimumSystemVersion' destroot/Library/Frameworks/macosx/hermes.framework/Resources/Info.plist
10.13

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 4, 2020
@alloy
Copy link
Contributor Author

alloy commented Dec 4, 2020

@Huxpro What’s the status re #418 and making CI pass?

@Huxpro
Copy link
Contributor

Huxpro commented Dec 4, 2020

@alloy Thanks. I haven't got chance working on #418. Could you please retarget this PR to the 0.7 branch (or maybe fire another one and keep this one)?

@alloy
Copy link
Contributor Author

alloy commented Dec 4, 2020

Ah gotcha. Will do 👍

@Huxpro Huxpro self-assigned this Dec 9, 2020
@Huxpro Huxpro changed the title [apple] Define the deployment target in the frameworks metadata [apple][v0.8] Define the deployment target in the frameworks metadata Jan 5, 2021
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Huxpro has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@Huxpro merged this pull request in f74ea80.

@alloy alloy deleted the add-deployment-target-metadata-to-apple-artefacts branch January 8, 2021 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
3 participants