Backport podspec and binary building to v0.4.1 #299
Conversation
facebook-github-bot
added
the
CLA Signed
alloy
force-pushed
the
add-podspec-for-macos-v0.4.1
branch
3 times, most recently
from
1590c59 to
4d20086
Compare
alloy
force-pushed
the
add-podspec-for-macos-v0.4.1
branch
from
4d20086 to
44a3fdd
Compare
Summary: The build is currently failing (possibly because 19.04 is EOL). This updates it to just use the latest Ubuntu. Pull Request resolved: facebook#215 Reviewed By: willholen Differential Revision: D21026727 Pulled By: neildhar fbshipit-source-id: 3b0bd7e286e8d2b21d3b7122e495c3fa31f9e41a
Summary: Builds are currently failing because the tzdata package requires user input while being installed via apt-get. Setting the environment variable `DEBIAN_FRONTEND` to `noninteractive` forces apt-get to bypass the requirement. Pull Request resolved: facebook#229 Reviewed By: tmikov Differential Revision: D21242342 Pulled By: neildhar fbshipit-source-id: 8f393ff785ec1f67e7ca9628dbb0cd85f2fff095
Summary: This change avoids future build failures due to user input requirements when installing packages via apt-get. Pull Request resolved: facebook#230 Reviewed By: tmikov Differential Revision: D21244023 Pulled By: neildhar fbshipit-source-id: ce694c6e9b7de42a9459afe9fe2479386bbeb51c
Instead packge the binaries in an extra layer of tarball, which also saves some bytes on-disk on platforms that don't need it.
alloy
changed the title
|
@willholen Ok, this should be good to go; I’ve tested the build artefact and the steps to create the NPM package locally with success. Can you publish the release? |
|
Could you update this with the same changes from https://github.com/facebook/hermes/pull/297/files/3e4904476bc65de821c7bb43d602a8da8e675b36 ? (there's a few "Show resolved" buttons to see what exactly they were) |
|
@willholen Good call 👍 Done. |
|
Hey @alloy, thanks for the work! Since we already have a 0.4.1 section in https://github.com/facebook/hermes/releases, I think we can make an 0.4.3 exclusively for macOS. Could you change the version in the code ( The plan is that we can only |
| project(Hermes | ||
| VERSION 0.4.2 | ||
| VERSION 0.4.1 |
|
|
||
| Pod::Spec.new do |spec| | ||
| spec.name = "hermes" | ||
| spec.version = "0.4.1" |
| @@ -0,0 +1,19 @@ | |||
| { | |||
| "name": "hermes-engine-darwin", | |||
| "version": "0.4.1", | |||
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "hermes-engine", | |||
| "version": "0.4.2-rc1", | |||
| "version": "0.4.1", | |||
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| // This must be consistent with the release_version in npm/package.json | |||
| // and the HERMES_RELEASE_VERSION in CMakeLists.txt | |||
| def release_version = "0.4.2-rc1" | |||
| def release_version = "0.4.1" | |||
|
@Huxpro Is it ok to not put the proxy code back that was added in the 0.4.2 RC, so it otherwise remains equal to the existing 0.4.1 release? |
Yes! The plan is to only turn on Proxy at RC releases (for now). |
|
Hey @alloy, since the PR looks otherwise great. I think we can just merge it and I will take care of the version bump thing. Thanks for the work! |
|
@Huxpro Awesome, thanks so much! 🙏 |
|
@Huxpro @willholen Could you give me a ping when you’ve published the macOS version of the package? |
Summary
Backport podspec and binary building to v0.4.1. Note that this reverts the 0.4.2-rc1 changes!
Test Plan
See steps to create a NPM package and use it with this RN macOS change.