Speed up Array.prototype.join() #1635
Open
+467
−264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70415235 |
Summary: The last commit added more tests, but the output that was compared wasn't precise. Improve the verbosity of the output. Differential Revision: D70370734
Summary: Improve the tests of `toReversed()` and fix the bug that was revealed. Differential Revision: D70370910
Summary: Add a fast path when the input is a dense array. Speed up the slow path: - Move SmallHermesValue-s around to avoid decoding and encoding when possible. - Only flush the GCScope when needed. - Efficiently store into the output array, since we know it is an array. The case of a non-dense input JSArray should be fairly fast compared to before. Have I benchmarked it? No. Differential Revision: D70372051
tmikov
pushed a commit
to tmikov/hermes
that referenced
this pull request
Mar 1, 2025
Summary: The improvement is based on the following ideas: - Optimistically assume the input array already contains strings and avoid copying them into a temporary array. - Switch to the slower path for the remaining elements, once a non-string is encountered. - Use faster access if the input is a dense array. Apparently this call is used by `print()`, so it is tested a lot implicitly, for example by the `array-push.js` test. Reviewed By: avp Differential Revision: D70415235
tmikov
force-pushed
the
export-D70415235-to-static_h
branch
from
c60074b to
8d916b4
Compare
Summary: Pull Request resolved: facebook#1635 The improvement is based on the following ideas: - Optimistically assume the input array already contains strings and avoid copying them into a temporary array. - Switch to the slower path for the remaining elements, once a non-string is encountered. - Use faster access if the input is a dense array. Apparently this call is used by `print()`, so it is tested a lot implicitly, for example by the `array-push.js` test. Reviewed By: avp Differential Revision: D70415235
|
This pull request was exported from Phabricator. Differential Revision: D70415235 |
tmikov
force-pushed
the
export-D70415235-to-static_h
branch
from
8d916b4 to
93f6f39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The improvement is based on the following ideas:
avoid copying them into a temporary array.
non-string is encountered.
Apparently this call is used by
print(), so it is tested a lotimplicitly, for example by the
array-push.jstest.Differential Revision: D70415235