Add Reflect[Symbol.toStringTag].

Summary: ECMA262 PR: tc39/ecma262#2057 Reviewed By: mhorowitz Differential Revision: D22737738 fbshipit-source-id: 275a890c5d304bebb83643ebcc6bdf6299dc6898
facebook · Jul 25, 2020 · 1d393b6 · 1d393b6
1 parent 8ec23f7
commit 1d393b6
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/lib/VM/JSLib/Reflect.cpp b/lib/VM/JSLib/Reflect.cpp
@@ -273,6 +273,17 @@ Handle<JSObject> createReflectObject(Runtime *runtime) {
   defineReflectMethod(Predefined::set, reflectSet, 3);
   defineReflectMethod(Predefined::setPrototypeOf, reflectSetPrototypeOf, 2);
 
+  DefinePropertyFlags dpf = DefinePropertyFlags::getDefaultNewPropertyFlags();
+  dpf.writable = 0;
+  dpf.enumerable = 0;
+  dpf.configurable = 1;
+  defineProperty(
+      runtime,
+      reflect,
+      Predefined::getSymbolID(Predefined::SymbolToStringTag),
+      runtime->getPredefinedStringHandle(Predefined::Reflect),
+      dpf);
+
   return reflect;
 }
 

diff --git a/test/hermes/reflect.js b/test/hermes/reflect.js
@@ -473,5 +473,10 @@ assert.equal(Reflect.setPrototypeOf(o, {}),
 assert.throws(_ => Reflect.setPrototypeOf(1, proto),
              TypeError);
 
+print('Symbol.toStringTag');
+// CHECK-LABEL: Symbol.toStringTag
+
+assert.equal(Reflect[Symbol.toStringTag], 'Reflect');
+
 print('done');
 // CHECK-LABEL: done