Fix OSS build for Python extensions #2370
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This diff fixes the OSS build for folly's Python extensions (`folly.iobuf` and `folly.executor` libraries), which seem to have been in an unmaintained state for a while now. Reviewed By: skcoirz Differential Revision: D68169324
|
This pull request was exported from Phabricator. Differential Revision: D68169324 |
|
This pull request has been merged in f1c1542. |
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Jan 17, 2025
Summary: X-link: facebook/folly#2370 This diff fixes the OSS build for folly's Python extensions (`folly.iobuf` and `folly.executor` libraries), which seem to have been in an unmaintained state for a while now. Reviewed By: skcoirz Differential Revision: D68169324 fbshipit-source-id: c65f5bd50ffeac32d3584b2b348ce5945863952e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This diff fixes the OSS build for folly's Python extensions (
folly.iobufandfolly.executorlibraries), which seem to have been in an unmaintained state for a while now.Reviewed By: skcoirz
Differential Revision: D68169324