Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compression namespace #700

Closed
RcRonco opened this issue Oct 30, 2017 · 1 comment
Closed

Compression namespace #700

RcRonco opened this issue Oct 30, 2017 · 1 comment

Comments

@RcRonco
Copy link

RcRonco commented Oct 30, 2017

Hi,
When compression moved from io to its own folder the namespace still stayed folly::io, which is quite confusing.
Maybe it should be in its own namespace or in the folly namespace, or even return the compression into io folder.

In compression Utils.h the namespace folly::io::compression exists, refactoring the namespaces of the compression folder will make it more consistent, I don`t mind to do it.

@Orvid
Copy link
Contributor

Orvid commented Oct 30, 2017

I believe the plan is to shift the namespace as well, we're just doing all of the physical moves first, then we'll be renaming a few things to make them more consistent (this included), and finally post a write-up of everything that moved and where it went :)

facebook-github-bot pushed a commit that referenced this issue Jun 21, 2024
Summary:
Renamespace these bits to `folly::compression` from `folly::io`, but leave aliases in place in `folly::io` for now.
Fixes: #700.

Differential Revision: D58819499

fbshipit-source-id: 5270a4bde3c0f6ba55d02e96d8d21070afc8e2fb
facebook-github-bot pushed a commit to facebook/hhvm that referenced this issue Jun 21, 2024
Summary:
Renamespace these bits to `folly::compression` from `folly::io`, but leave aliases in place in `folly::io` for now.
Fixes: facebook/folly#700.

Differential Revision: D58819499

fbshipit-source-id: 5270a4bde3c0f6ba55d02e96d8d21070afc8e2fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants