Skip to content

Commit

Permalink
Remove extraneous semicolon from folly/io/async/AsyncSocket.cpp
Browse files Browse the repository at this point in the history
Summary:
Extraneous semicolons are a code smell and can mask more serious problems. `-Wextra-semi-stmt` finds them.

This diff removes an extraneous semicolon or adjusts a macro so that a semicolon is required after the macro (making it look like a standard function).

This file is drawn from a heavy-hitting list, so fixing this problem will allow *many* other files to take advantage of the safety `-Wextra-semi-stmt` offers.

This should be a low-risk diff: if it compiles, it works.

Reviewed By: meyering

Differential Revision: D51631129

fbshipit-source-id: 744ea519bab352dc1c575c44ec5d16777d03a648
  • Loading branch information
r-barnes authored and facebook-github-bot committed Nov 30, 2023
1 parent 7e330ad commit a0ccd7f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion folly/io/async/AsyncSocket.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3283,7 +3283,7 @@ void AsyncSocket::handleRead() noexcept {
break;
case ReadCode::READ_DONE:
return;
};
}
}

if (readCallback_ && eventBase_ == originalEventBase) {
Expand Down

0 comments on commit a0ccd7f

Please sign in to comment.