Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix linux cmake test disablement and related OOM (#2146)
Summary: fix linux cmake test disablement and related OOM Fix the folly linux github CI: * fix disabling the failing AtomicUnorderedInsertMap.DISABLEDMegaMap test as ctest wasn't filtering it out * fix disabling ThreadLocal.SHAREDLibraryTestName when not building shared lib The first one also fixes OOM that reliably OOM killed my terminal when running tests locally with > 2 jobs Pull Request resolved: #2146 Test Plan: Run tests locally with: ``` ./build/fbcode_builder/getdeps.py --allow-system-packages test --num-jobs 2 --src-dir=. folly ``` Before: ``` Start 1883: atomic_unordered_map_test.AtomicUnorderedInsertMap.DISABLEDMegaMap 1882/3090 Test #1883: atomic_unordered_map_test.AtomicUnorderedInsertMap.DISABLEDMegaMap ...................................***Failed 0.00 sec Note: Google Test filter = AtomicUnorderedInsertMap.DISABLEDMegaMap [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from AtomicUnorderedInsertMap [ RUN ] AtomicUnorderedInsertMap.DISABLEDMegaMap unknown file: Failure C++ exception with description "Cannot allocate memory" thrown in the test body. [ FAILED ] AtomicUnorderedInsertMap.DISABLEDMegaMap (0 ms) [----------] 1 test from AtomicUnorderedInsertMap (0 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test suite ran. (0 ms total) [ PASSED ] 0 tests. [ FAILED ] 1 test, listed below: [ FAILED ] AtomicUnorderedInsertMap.DISABLEDMegaMap 1 FAILED TEST ... 1/1 Test #2774: thread_local_test.ThreadLocal.SHAREDLibraryTestName ...***Failed 0.00 sec Note: Google Test filter = ThreadLocal.SHAREDLibraryTestName [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from ThreadLocal [ RUN ] ThreadLocal.SHAREDLibraryTestName unknown file: Failure C++ exception with description "missing: folly/test/thread_local_test_lib.so" thrown in the test body. [ FAILED ] ThreadLocal.SHAREDLibraryTestName (0 ms) [----------] 1 test from ThreadLocal (0 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test suite ran. (0 ms total) [ PASSED ] 0 tests. [ FAILED ] 1 test, listed below: [ FAILED ] ThreadLocal.SHAREDLibraryTestName ``` After, works --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/folly/pull/2146). * #2084 * #2074 * #2068 * __->__ #2146 Reviewed By: Gownta Differential Revision: D53830611 Pulled By: Orvid fbshipit-source-id: c3eac882f2522996f897b29f5bf7d8622c1f6ceb
- Loading branch information