Move experimental/symbolizer/{tool,test} to debugging/symbolizer

Summary: tsia Differential Revision: D59683961 fbshipit-source-id: 53bb2df85f6e1189143a57c88e0bf88fea3cd3da
facebook · Jul 13, 2024 · 2d9c0a3 · 2d9c0a3
1 parent 9a94129
commit 2d9c0a3
Show file tree

Hide file tree

Showing 25 changed files with 31 additions and 31 deletions.
diff --git a/.github/scripts/bad_targets b/.github/scripts/bad_targets
@@ -5,6 +5,8 @@ root//folly/debugging/exception_tracer:exception_tracer
 root//folly/debugging/exception_tracer:exception_tracer_callbacks
 root//folly/debugging/exception_tracer:smart_exception_stack_trace_hooks
 root//folly/debugging/exception_tracer:smart_exception_tracer
+root//folly/debugging/symbolizer/tool:folly-addr2line
+root//folly/debugging/symbolizer/tool:libFollySegFault.so
 root//folly/docs/examples/folly:baton_demo
 root//folly/docs/examples/folly:cancellation_callback_demo
 root//folly/docs/examples/folly:cancellation_source_demo
@@ -37,8 +39,6 @@ root//folly/docs/examples/folly/hash:hash_demo
 root//folly/docs/examples/folly/io:i_o_buf_demo
 root//folly/experimental/io:async_io
 root//folly/experimental/io:simple_async_io
-root//folly/experimental/symbolizer/tool:folly-addr2line
-root//folly/experimental/symbolizer/tool:libFollySegFault.so
 root//folly/logging/example:example
 root//folly/python:executor_lib
 root//folly/python:fibers_lib

diff --git a/folly/experimental/symbolizer/test/BUCK → folly/debugging/symbolizer/test/BUCK b/folly/experimental/symbolizer/test/BUCK → folly/debugging/symbolizer/test/BUCK
@@ -98,7 +98,7 @@ custom_unittest(
 # custom_unittest(
 #     name = "gnu_debuglink_test_small_sigaltstack",
 #     command = [
-#         "folly/experimental/symbolizer/test/gnu_debuglink_test.sh",
+#         "folly/debugging/symbolizer/test/gnu_debuglink_test.sh",
 #         "$(location :small_sigaltstack_crash)",
 #     ],
 #     type = "json",

diff --git a/folly/experimental/symbolizer/test/Crash.cpp → folly/debugging/symbolizer/test/Crash.cpp b/folly/experimental/symbolizer/test/Crash.cpp → folly/debugging/symbolizer/test/Crash.cpp
diff --git a/...mental/symbolizer/test/DwarfBenchmark.cpp → ...ugging/symbolizer/test/DwarfBenchmark.cpp b/...mental/symbolizer/test/DwarfBenchmark.cpp → ...ugging/symbolizer/test/DwarfBenchmark.cpp
@@ -16,10 +16,10 @@
 
 #include <folly/Benchmark.h>
 #include <folly/Range.h>
+#include <folly/debugging/symbolizer/test/SymbolizerTestUtils.h>
 #include <folly/experimental/symbolizer/Dwarf.h>
 #include <folly/experimental/symbolizer/SymbolizedFrame.h>
 #include <folly/experimental/symbolizer/Symbolizer.h>
-#include <folly/experimental/symbolizer/test/SymbolizerTestUtils.h>
 #include <folly/portability/GFlags.h>
 
 #if FOLLY_HAVE_ELF && FOLLY_HAVE_DWARF

diff --git a/.../experimental/symbolizer/test/ElfTest.cpp → folly/debugging/symbolizer/test/ElfTest.cpp b/.../experimental/symbolizer/test/ElfTest.cpp → folly/debugging/symbolizer/test/ElfTest.cpp
diff --git a/...mental/symbolizer/test/LineReaderTest.cpp → ...ugging/symbolizer/test/LineReaderTest.cpp b/...mental/symbolizer/test/LineReaderTest.cpp → ...ugging/symbolizer/test/LineReaderTest.cpp
diff --git a/...tal/symbolizer/test/SignalHandlerTest.cpp → ...ing/symbolizer/test/SignalHandlerTest.cpp b/...tal/symbolizer/test/SignalHandlerTest.cpp → ...ing/symbolizer/test/SignalHandlerTest.cpp
@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-#include <folly/experimental/symbolizer/test/SignalHandlerTest.h>
+#include <folly/debugging/symbolizer/test/SignalHandlerTest.h>
 
 #include <folly/experimental/symbolizer/SignalHandler.h>
 

diff --git a/...ental/symbolizer/test/SignalHandlerTest.h → ...gging/symbolizer/test/SignalHandlerTest.h b/...ental/symbolizer/test/SignalHandlerTest.h → ...gging/symbolizer/test/SignalHandlerTest.h
diff --git a/...symbolizer/test/SmallSigAltStackCrash.cpp → ...symbolizer/test/SmallSigAltStackCrash.cpp b/...symbolizer/test/SmallSigAltStackCrash.cpp → ...symbolizer/test/SmallSigAltStackCrash.cpp
diff --git a/...l/symbolizer/test/StackTraceBenchmark.cpp → ...g/symbolizer/test/StackTraceBenchmark.cpp b/...l/symbolizer/test/StackTraceBenchmark.cpp → ...g/symbolizer/test/StackTraceBenchmark.cpp
diff --git a/...mbolizer/test/StackTraceSizeLimitTest.cpp → ...mbolizer/test/StackTraceSizeLimitTest.cpp b/...mbolizer/test/StackTraceSizeLimitTest.cpp → ...mbolizer/test/StackTraceSizeLimitTest.cpp
diff --git a/...mental/symbolizer/test/StackTraceTest.cpp → ...ugging/symbolizer/test/StackTraceTest.cpp b/...mental/symbolizer/test/StackTraceTest.cpp → ...ugging/symbolizer/test/StackTraceTest.cpp
@@ -230,7 +230,7 @@ TEST(StackTraceTest, TerseFileAndLineStackTracePrinterOutput) {
   printer.println(addresses, 0);
 
   // Match a sequence of file+line results that should appear as:
-  // ./folly/experimental/symbolizer/test/StackTraceTest.cpp:202
+  // ./folly/debugging/symbolizer/test/StackTraceTest.cpp:202
   // or:
   // (unknown)
   boost::regex regex("((([^:]*:[0-9]*)|(\\(unknown\\)))\n)+");

diff --git a/...l/symbolizer/test/SymbolizedFrameTest.cpp → ...g/symbolizer/test/SymbolizedFrameTest.cpp b/...l/symbolizer/test/SymbolizedFrameTest.cpp → ...g/symbolizer/test/SymbolizedFrameTest.cpp
diff --git a/...mental/symbolizer/test/SymbolizerTest.cpp → ...ugging/symbolizer/test/SymbolizerTest.cpp b/...mental/symbolizer/test/SymbolizerTest.cpp → ...ugging/symbolizer/test/SymbolizerTest.cpp
@@ -25,10 +25,10 @@
 #include <folly/Range.h>
 #include <folly/ScopeGuard.h>
 #include <folly/String.h>
+#include <folly/debugging/symbolizer/test/SymbolizerTestUtils.h>
 #include <folly/experimental/symbolizer/ElfCache.h>
 #include <folly/experimental/symbolizer/SymbolizedFrame.h>
 #include <folly/experimental/symbolizer/detail/Debug.h>
-#include <folly/experimental/symbolizer/test/SymbolizerTestUtils.h>
 #include <folly/portability/Filesystem.h>
 #include <folly/portability/GTest.h>
 #include <folly/portability/Unistd.h>
@@ -267,14 +267,14 @@ TEST(SymbolizerTest, InlineFunctionBasic) {
       frames.frames[4],
       "inlineA_lfind",
       "folly::symbolizer::test::inlineA_lfind()",
-      "folly/experimental/symbolizer/test/SymbolizerTestUtils-inl.h",
+      "folly/debugging/symbolizer/test/SymbolizerTestUtils-inl.h",
       kLineno_lfind);
 
   expectFrameEq(
       frames.frames[5],
       "inlineB_inlineA_lfind",
       "folly::symbolizer::test::inlineB_inlineA_lfind()",
-      "folly/experimental/symbolizer/test/SymbolizerTestUtils-inl.h",
+      "folly/debugging/symbolizer/test/SymbolizerTestUtils-inl.h",
       kLineno_inlineA_lfind);
 
   FrameArray<100> frames2;
@@ -314,13 +314,13 @@ TEST(SymbolizerTest, InlineFunctionWithoutEnoughFrames) {
       limitedFrames[0],
       "inlineB_inlineA_lfind",
       "folly::symbolizer::test::inlineB_inlineA_lfind()",
-      "folly/experimental/symbolizer/test/SymbolizerTestUtils-inl.h",
+      "folly/debugging/symbolizer/test/SymbolizerTestUtils-inl.h",
       kLineno_inlineA_lfind);
   expectFrameEq(
       limitedFrames[1],
       "call_B_A_lfind",
       "folly::symbolizer::test::call_B_A_lfind()",
-      "folly/experimental/symbolizer/test/SymbolizerTest.cpp",
+      "folly/debugging/symbolizer/test/SymbolizerTest.cpp",
       kLineno_inlineB_inlineA_lfind);
 }
 
@@ -340,21 +340,21 @@ TEST(SymbolizerTest, InlineFunctionInLexicalBlock) {
       frames.frames[4],
       "inlineA_lfind",
       "folly::symbolizer::test::inlineA_lfind()",
-      "folly/experimental/symbolizer/test/SymbolizerTestUtils-inl.h",
+      "folly/debugging/symbolizer/test/SymbolizerTestUtils-inl.h",
       kLineno_lfind);
 
   expectFrameEq(
       frames.frames[5],
       "inlineB_inlineA_lfind",
       "folly::symbolizer::test::inlineB_inlineA_lfind()",
-      "folly/experimental/symbolizer/test/SymbolizerTestUtils-inl.h",
+      "folly/debugging/symbolizer/test/SymbolizerTestUtils-inl.h",
       kLineno_inlineA_lfind);
 
   expectFrameEq(
       frames.frames[6],
       "lexicalBlock_inlineB_inlineA_lfind",
       "folly::symbolizer::test::lexicalBlock_inlineB_inlineA_lfind()",
-      "folly/experimental/symbolizer/test/SymbolizerTestUtils.cpp",
+      "folly/debugging/symbolizer/test/SymbolizerTestUtils.cpp",
       kLineno_inlineB_inlineA_lfind);
 
   printFrames(frames);
@@ -377,7 +377,7 @@ TEST(SymbolizerTest, InlineFunctionInDifferentCompilationUnit) {
       frames.frames[5],
       "inlineLTO_inlineA_lfind",
       "folly::symbolizer::test::inlineLTO_inlineA_lfind()",
-      "folly/experimental/symbolizer/test/SymbolizerTestUtils.cpp",
+      "folly/debugging/symbolizer/test/SymbolizerTestUtils.cpp",
       kLineno_inlineA_lfind);
 }
 
@@ -397,14 +397,14 @@ TEST(SymbolizerTest, InlineClassMemberFunctionSameFile) {
       frames.frames[4],
       "inlineA_lfind",
       "folly::symbolizer::test::inlineA_lfind()",
-      "folly/experimental/symbolizer/test/SymbolizerTestUtils-inl.h",
+      "folly/debugging/symbolizer/test/SymbolizerTestUtils-inl.h",
       kLineno_lfind);
 
   expectFrameEq(
       frames.frames[5],
       "memberInline_inlineA_lfind",
       "folly::symbolizer::test::ClassSameFile::memberInline_inlineA_lfind() const",
-      "folly/experimental/symbolizer/test/SymbolizerTestUtils.cpp",
+      "folly/debugging/symbolizer/test/SymbolizerTestUtils.cpp",
       kLineno_inlineA_lfind);
 }
 
@@ -424,14 +424,14 @@ TEST(SymbolizerTest, StaticInlineClassMemberFunctionSameFile) {
       frames.frames[4],
       "inlineA_lfind",
       "folly::symbolizer::test::inlineA_lfind()",
-      "folly/experimental/symbolizer/test/SymbolizerTestUtils-inl.h",
+      "folly/debugging/symbolizer/test/SymbolizerTestUtils-inl.h",
       kLineno_lfind);
 
   expectFrameEq(
       frames.frames[5],
       "staticMemberInline_inlineA_lfind",
       "folly::symbolizer::test::ClassSameFile::staticMemberInline_inlineA_lfind()",
-      "folly/experimental/symbolizer/test/SymbolizerTestUtils.cpp",
+      "folly/debugging/symbolizer/test/SymbolizerTestUtils.cpp",
       kLineno_inlineA_lfind);
 }
 
@@ -451,14 +451,14 @@ TEST(SymbolizerTest, InlineClassMemberFunctionInDifferentFile) {
       frames.frames[4],
       "inlineA_lfind",
       "folly::symbolizer::test::inlineA_lfind()",
-      "folly/experimental/symbolizer/test/SymbolizerTestUtils-inl.h",
+      "folly/debugging/symbolizer/test/SymbolizerTestUtils-inl.h",
       kLineno_lfind);
 
   expectFrameEq(
       frames.frames[5],
       "memberInline_inlineA_lfind",
       "folly::symbolizer::test::ClassDifferentFile::memberInline_inlineA_lfind() const",
-      "folly/experimental/symbolizer/test/SymbolizerTestUtils-inl.h",
+      "folly/debugging/symbolizer/test/SymbolizerTestUtils-inl.h",
       kLineno_inlineA_lfind);
 }
 
@@ -478,14 +478,14 @@ TEST(SymbolizerTest, StaticInlineClassMemberFunctionInDifferentFile) {
       frames.frames[4],
       "inlineA_lfind",
       "folly::symbolizer::test::inlineA_lfind()",
-      "folly/experimental/symbolizer/test/SymbolizerTestUtils-inl.h",
+      "folly/debugging/symbolizer/test/SymbolizerTestUtils-inl.h",
       kLineno_lfind);
 
   expectFrameEq(
       frames.frames[5],
       "staticMemberInline_inlineA_lfind",
       "folly::symbolizer::test::ClassDifferentFile::staticMemberInline_inlineA_lfind()",
-      "folly/experimental/symbolizer/test/SymbolizerTestUtils-inl.h",
+      "folly/debugging/symbolizer/test/SymbolizerTestUtils-inl.h",
       kLineno_inlineA_lfind);
 }
 
@@ -528,14 +528,14 @@ TEST(SymbolizerTest, InlineFunctionWithCache) {
       frames.frames[4],
       "inlineA_lfind",
       "folly::symbolizer::test::inlineA_lfind()",
-      "folly/experimental/symbolizer/test/SymbolizerTestUtils-inl.h",
+      "folly/debugging/symbolizer/test/SymbolizerTestUtils-inl.h",
       kLineno_lfind);
 
   expectFrameEq(
       frames.frames[5],
       "inlineB_inlineA_lfind",
       "folly::symbolizer::test::inlineB_inlineA_lfind()",
-      "folly/experimental/symbolizer/test/SymbolizerTestUtils-inl.h",
+      "folly/debugging/symbolizer/test/SymbolizerTestUtils-inl.h",
       kLineno_inlineA_lfind);
 
   FrameArray<100> frames2;

diff --git a/...symbolizer/test/SymbolizerTestUtils-inl.h → ...symbolizer/test/SymbolizerTestUtils-inl.h b/...symbolizer/test/SymbolizerTestUtils-inl.h → ...symbolizer/test/SymbolizerTestUtils-inl.h
@@ -18,7 +18,7 @@
 
 #pragma once
 
-#include <folly/experimental/symbolizer/test/SymbolizerTestUtils.h>
+#include <folly/debugging/symbolizer/test/SymbolizerTestUtils.h>
 
 extern "C" {
 // Fwd declare instead of #include <stdlib.h> to minimize generated DWARF.

diff --git a/...l/symbolizer/test/SymbolizerTestUtils.cpp → ...g/symbolizer/test/SymbolizerTestUtils.cpp b/...l/symbolizer/test/SymbolizerTestUtils.cpp → ...g/symbolizer/test/SymbolizerTestUtils.cpp
@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-#include <folly/experimental/symbolizer/test/SymbolizerTestUtils.h>
+#include <folly/debugging/symbolizer/test/SymbolizerTestUtils.h>
 
 // NOTE: To simplify generated DWARF keep #includes to a minimum.
 

diff --git a/...tal/symbolizer/test/SymbolizerTestUtils.h → ...ing/symbolizer/test/SymbolizerTestUtils.h b/...tal/symbolizer/test/SymbolizerTestUtils.h → ...ing/symbolizer/test/SymbolizerTestUtils.h
@@ -66,4 +66,4 @@ class ClassDifferentFile {
 } // namespace symbolizer
 } // namespace folly
 
-#include <folly/experimental/symbolizer/test/SymbolizerTestUtils-inl.h>
+#include <folly/debugging/symbolizer/test/SymbolizerTestUtils-inl.h>
diff --git a/...ntal/symbolizer/test/compare-addr2line.sh → ...ging/symbolizer/test/compare-addr2line.sh b/...ntal/symbolizer/test/compare-addr2line.sh → ...ging/symbolizer/test/compare-addr2line.sh
diff --git a/...tal/symbolizer/test/gnu_debuglink_test.sh → ...ing/symbolizer/test/gnu_debuglink_test.sh b/...tal/symbolizer/test/gnu_debuglink_test.sh → ...ing/symbolizer/test/gnu_debuglink_test.sh
diff --git a/...olizer/test/symbolizer_dwp_compability.sh → ...olizer/test/symbolizer_dwp_compability.sh b/...olizer/test/symbolizer_dwp_compability.sh → ...olizer/test/symbolizer_dwp_compability.sh
diff --git a/...olizer/test/validate_folly_symbolizer.bzl → ...olizer/test/validate_folly_symbolizer.bzl b/...olizer/test/validate_folly_symbolizer.bzl → ...olizer/test/validate_folly_symbolizer.bzl
@@ -105,8 +105,8 @@ def validate_folly_symbolizer(name, binary):
     custom_unittest(
         name = name,
         command = [
-            "$(exe //folly/experimental/symbolizer/test:compare-addr2line.sh)",
-            "$(location //folly/experimental/symbolizer/tool:folly-addr2line)",
+            "$(exe //folly/debugging/symbolizer/test:compare-addr2line.sh)",
+            "$(location //folly/debugging/symbolizer/tool:folly-addr2line)",
             "$(location //third-party-buck/platform010/build/llvm-fb/15:bin/llvm-addr2line)",
             "$(location {})".format(binary),
         ],
@@ -121,7 +121,7 @@ def validate_symbolizer_dwp(name, binary):
         custom_unittest(
             name = name,
             command = [
-                "$(exe //folly/experimental/symbolizer/test:symbolizer_dwp_compability.sh)",
+                "$(exe //folly/debugging/symbolizer/test:symbolizer_dwp_compability.sh)",
                 "$(location {})".format(binary),
                 "$(location {}[dwp])".format(binary),
                 config.get_build_mode(),

diff --git a/...xperimental/symbolizer/tool/Addr2Line.cpp → ...y/debugging/symbolizer/tool/Addr2Line.cpp b/...xperimental/symbolizer/tool/Addr2Line.cpp → ...y/debugging/symbolizer/tool/Addr2Line.cpp
diff --git a/folly/experimental/symbolizer/tool/BUCK → folly/debugging/symbolizer/tool/BUCK b/folly/experimental/symbolizer/tool/BUCK → folly/debugging/symbolizer/tool/BUCK
diff --git a/...erimental/symbolizer/tool/LibSegFault.cpp → ...debugging/symbolizer/tool/LibSegFault.cpp b/...erimental/symbolizer/tool/LibSegFault.cpp → ...debugging/symbolizer/tool/LibSegFault.cpp
diff --git a/...tal/symbolizer/tool/libFollySegFault.so.v → ...ing/symbolizer/tool/libFollySegFault.so.v b/...tal/symbolizer/tool/libFollySegFault.so.v → ...ing/symbolizer/tool/libFollySegFault.so.v