Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align flow-parser with babylon v7 #4789

Closed
danez opened this issue Sep 3, 2017 · 3 comments
Closed

Align flow-parser with babylon v7 #4789

danez opened this issue Sep 3, 2017 · 3 comments

Comments

@danez
Copy link
Contributor

danez commented Sep 3, 2017

Hi,

we are getting close to release a beta of v7 of babel soon.

We changed some things in v7 in coordination with you guys, and this issue is a reminder to integrate this changes into flow:

Create separate Variance Node

As coordinated with @samwgoldman the variance should be represented as separate node, which is already done in babel v7. Flow should be updated accordingly
Related tickets: babel/babel#4722, babel/babel#4697, babel/babylon#161, babel/babylon#333

Add method property to FunctionTypeAnnotation node

This was discussed and seems agreed on. babylon has an open PR for this: babel/babylon/334
Related tickets: babel/babylon#331

I would create PRs for this myself, but well OCaml :)

Thanks.

//cc @samwgoldman @mroch

@mroch
Copy link
Contributor

mroch commented Dec 8, 2017

Method property added in 622bbc4

@danez It looks like babel/babylon#331 became babel/babel#6704 and is still open. its PR was closed without being merged.

@danez
Copy link
Contributor Author

danez commented Dec 12, 2017

Thanks

@samwgoldman
Copy link
Member

I have a change pending review internally for the variance node. Just waiting on @mroch to review :)

facebook-github-bot pushed a commit that referenced this issue Dec 13, 2017
Summary: #4789

Reviewed By: mroch

Differential Revision: D6524653

fbshipit-source-id: 2b493509c57599efbd5e3080fd2b3f479ebb11f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants