Skip to content

Commit

Permalink
[flow][libdef][EZ] Remove shadowed NodeFilter in builtin libdef
Browse files Browse the repository at this point in the history
Summary:
This entry has been completely shadowed by the one in dom.js: https://github.com/facebook/flow/blob/289888e35b083b773c8b01980040b023a10d3116/lib/dom.js#L4430. This diff just removes it.

Changelog: [internal]

Reviewed By: panagosg7

Differential Revision: D69784626

fbshipit-source-id: 7de61b4cd6ce0b09e6e52d33c9aaf2ada08e839d
  • Loading branch information
SamChou19815 authored and facebook-github-bot committed Feb 18, 2025
1 parent 8b0a9bc commit 0cfac72
Show file tree
Hide file tree
Showing 3 changed files with 156 additions and 177 deletions.
21 changes: 0 additions & 21 deletions lib/bom.js
Original file line number Diff line number Diff line change
Expand Up @@ -849,27 +849,6 @@ declare class ResizeObserver {
disconnect(): void;
}

declare var NodeFilter: {
acceptNode(n: Node): number,
SHOW_ENTITY_REFERENCE: number,
SHOW_NOTATION: number,
SHOW_ENTITY: number,
SHOW_DOCUMENT: number,
SHOW_PROCESSING_INSTRUCTION: number,
FILTER_REJECT: number,
SHOW_CDATA_SECTION: number,
FILTER_ACCEPT: number,
SHOW_ALL: number,
SHOW_DOCUMENT_TYPE: number,
SHOW_TEXT: number,
SHOW_ELEMENT: number,
SHOW_COMMENT: number,
FILTER_SKIP: number,
SHOW_ATTRIBUTE: number,
SHOW_DOCUMENT_FRAGMENT: number,
...
};

declare class CloseEvent extends Event {
code: number;
reason: string;
Expand Down
8 changes: 4 additions & 4 deletions tests/bom/bom.exp
Original file line number Diff line number Diff line change
Expand Up @@ -662,8 +662,8 @@ Cannot assign `headers.get(...)` to `b` because null [1] is incompatible with st
^^^^^^^^^^^^^^^^^^

References:
<BUILTINS>/bom.js:1599:24
1599| get(name: string): null | string;
<BUILTINS>/bom.js:1578:24
1578| get(name: string): null | string;
^^^^ [1]
Headers.js:8:10
8| const b: string = headers.get('foo'); // incorrect
Expand Down Expand Up @@ -980,8 +980,8 @@ Cannot assign `params.get(...)` to `b` because null [1] is incompatible with str
^^^^^^^^^^^^^^^^^

References:
<BUILTINS>/bom.js:1616:24
1616| get(name: string): null | string;
<BUILTINS>/bom.js:1595:24
1595| get(name: string): null | string;
^^^^ [1]
URLSearchParams.js:8:10
8| const b: string = params.get('foo'); // incorrect
Expand Down
Loading

0 comments on commit 0cfac72

Please sign in to comment.