Make iOS 9 compatible again. #874
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Note that even with this change, there is API being used in Folly that’s also iOS 10 only, but that was also the case with FlipperKit
|
There was a problem hiding this comment.
@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
I see that the cause of the build failure on master that I mentioned has already been fixed 9878220 |
passy
approved these changes
Mar 6, 2020
iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutPlugin/descriptors/SKViewDescriptor.mm
Outdated
Show resolved
Hide resolved
alloy
force-pushed
the
make-ios-9-compatible
branch
from
d2ae58c
to
16ca010
Compare
|
@alloy has updated the pull request. Re-import the pull request |
There was a problem hiding this comment.
@passy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
mweststrate
added a commit
to mweststrate/react-native
that referenced
this pull request
Mar 10, 2020
FlipperKit 0.33.1 contains facebook/flipper#874 and is also compatible with the next react-native-flipper version
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Mar 10, 2020
…pper (#28277) Summary: This pull request re-applies #28225, thereby reverting 4bb1794, this time bumping to FlipperKit 0.33.1 which is again compatible with iOS 9 (thanks to facebook/flipper#874) This is the iOS counterpart of #28275 ## Changelog [iOS] [Changed] - Upgrade Flipper dependency to 0.33.1 Pull Request resolved: #28277 Test Plan: * Bumped the version in our Flipper / RN integration test app first, that runs on 0.62-rc.5, verified everything still works there. * CI  Reviewed By: mweststrate Differential Revision: D20369106 Pulled By: TheSavior fbshipit-source-id: dfeb0446e7f29684a266eca5d0e29ac42cef2ef3
alloy
pushed a commit
to facebook/react-native
that referenced
this pull request
Mar 11, 2020
…pper (#28277) Summary: This pull request re-applies #28225, thereby reverting 4bb1794, this time bumping to FlipperKit 0.33.1 which is again compatible with iOS 9 (thanks to facebook/flipper#874) This is the iOS counterpart of #28275 [iOS] [Changed] - Upgrade Flipper dependency to 0.33.1 Pull Request resolved: #28277 Test Plan: * Bumped the version in our Flipper / RN integration test app first, that runs on 0.62-rc.5, verified everything still works there. * CI  Reviewed By: mweststrate Differential Revision: D20369106 Pulled By: TheSavior fbshipit-source-id: dfeb0446e7f29684a266eca5d0e29ac42cef2ef3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
React Native v0.62.0’s template still uses iOS 9 as deployment target, bumping it to 10 this late in the release cycle is probably not a good idea, so instead I made this tiny change to make it iOS 9 compatible again.
v0.32.2tag, asmasterwas giving me a build failure and in any case it would be better to release just this change as a patch release so the RNv0.62.0-rc.3release can go out without having to test Flipper as thoroughly again.Changelog
Make FlipperKit compatible with iOS 9 again.
Test Plan
pod installwith a Podfile that has iOS 9 as its deployment target passes again.v0.62.0-rc.3template works.