Skip to content
This repository has been archived by the owner on Nov 22, 2024. It is now read-only.

Commit

Permalink
Fix screen recording bug on Pixel devices
Browse files Browse the repository at this point in the history
Summary:
Pixels don't seem to allow modifying the modification time
of files on the "sdcard". You can repro this by getting a Pixel
device and running

```
$ adb shell touch /sdcard/boop
$ adb shell touch /sdcard/boop
touch: '/sdcard/boop': Invalid argument
```

Access time seems to work, strangely enough, but I'd rather
not play games and just create an empty file instead with echo.

Reviewed By: danielbuechele

Differential Revision: D13941381

fbshipit-source-id: 1321482a07a6698aa5eaf71e5a022c8e7dfe0b18
  • Loading branch information
passy authored and facebook-github-bot committed Feb 4, 2019
1 parent 3d03f44 commit 64c8163
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/chrome/ScreenCaptureButtons.js
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ class ScreenCaptureButtons extends Component<Props, State> {

this.executeShell(
selectedDevice,
`mkdir -p "${devicePath}" && touch "${devicePath}/.nomedia"`,
`mkdir -p "${devicePath}" && echo -n > "${devicePath}/.nomedia"`,
)
.then(output => {
if (output) {
Expand Down

0 comments on commit 64c8163

Please sign in to comment.