Skip to content
This repository has been archived by the owner on Nov 22, 2024. It is now read-only.

Commit

Permalink
Remove legacy notice for FireAndForgetResponder
Browse files Browse the repository at this point in the history
Summary:
Quoting lblasa:
History trip:
- It was used at the beginning of times with RSocket.
- RSocket introduced an RPC mechanism so a new responder was introduced which used it, thus making this responder legacy.
- WebSockets is introduced which doesn't have an RPC mechanism by default so this responder became the new non-legacy responder

Reviewed By: lblasa

Differential Revision: D37994288

fbshipit-source-id: 2458aed129058a5bfaafd607e73c52867d9713cf
  • Loading branch information
aigoncharov authored and facebook-github-bot committed Jul 20, 2022
1 parent 55b7ef9 commit 342bb2b
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions xplat/Flipper/FireAndForgetBasedFlipperResponder.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,6 @@
namespace facebook {
namespace flipper {

/* Responder for responding to legacy flipper applications.
Originally, flipper desktop used fireAndForget for all messages, so calling
the SDK would send a fire and forget message, to which the SDK would respond
with another one, with an id field that flipper uses to map it to the
original request. This Responder should be used when such requests are
received.
*/
class FireAndForgetBasedFlipperResponder : public FlipperResponder {
public:
FireAndForgetBasedFlipperResponder(
Expand Down

0 comments on commit 342bb2b

Please sign in to comment.