Skip to content

Commit

Permalink
Remove extraneous semicolon from thrift/compiler/generate/t_java_depr…
Browse files Browse the repository at this point in the history
…ecated_generator.cc

Summary:
Extraneous semicolons are a code smell and can mask more serious problems. `-Wextra-semi-stmt` finds them.

This diff removes an extraneous semicolon or adjusts a macro so that a semicolon is required after the macro (making it look like a standard function).

This file is drawn from a heavy-hitting list, so fixing this problem will allow *many* other files to take advantage of the safety `-Wextra-semi-stmt` offers.

This should be a low-risk diff: if it compiles, it works.

Reviewed By: meyering, vitaut

Differential Revision: D51631146

fbshipit-source-id: 1ded7584955950418f5149ccc6245a74c490aaaf
  • Loading branch information
r-barnes authored and facebook-github-bot committed Nov 30, 2023
1 parent 2d2a6f0 commit eeda26d
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion thrift/compiler/generate/t_java_deprecated_generator.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3769,7 +3769,6 @@ string t_java_deprecated_generator::declare_field(
result += " = new " + type_name(ttype, false, true) + "()";
} else {
result += " = new " + type_name(ttype, false, true) + "()";
;
}
}
return result + ";";
Expand Down

0 comments on commit eeda26d

Please sign in to comment.