Skip to content

Commit

Permalink
remember to return error
Browse files Browse the repository at this point in the history
Summary:
This bug was created in D60825154

We to return the error
If we do not, we set the client to nil and this results in a nil pointer exception later that was found in production

Reviewed By: yfeldblum

Differential Revision: D64238799

fbshipit-source-id: c05195ca89d9f10c086873e8951e127d2ba44ece
  • Loading branch information
Walter Schulze authored and facebook-github-bot committed Oct 11, 2024
1 parent d9789ed commit acf9956
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion thrift/lib/go/thrift/rocket_rsocket_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ func (r *rsocketClient) SendSetup(serverMetadataPush OnServerMetadataPush) error
clientStarter := clientBuilder.Acceptor(acceptor(serverMetadataPush))
client, err := clientStarter.Transport(transporter(r.conn)).Start(context.Background())
r.client = client
return nil
return err
}

func acceptor(onMetadataPush OnServerMetadataPush) func(_ context.Context, socket rsocket.RSocket) rsocket.RSocket {
Expand Down

0 comments on commit acf9956

Please sign in to comment.