Skip to content

Commit

Permalink
Fix OSS build
Browse files Browse the repository at this point in the history
Summary:
Newer versions of {fmt} have `fmt::join` in `fmt/ranges.h`.

Fixes:

```
thrift/compiler/gen/cpp/name_resolver.cc:306:33: error: ‘join’ is not a member of ‘fmt’
  306 |   return fmt::format("{}", fmt::join(components, "::"));
      |                                 ^~~~
```

https://github.com/facebook/fbthrift/actions/runs/11220918018/job/31190106419

Reviewed By: yoney

Differential Revision: D64007198

fbshipit-source-id: e7f5658bf54225aebcd1e326e72aac407535e4ca
  • Loading branch information
vitaut authored and facebook-github-bot committed Oct 8, 2024
1 parent d8cb254 commit 7f6edca
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion thrift/compiler/gen/cpp/name_resolver.cc
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

#include <stdexcept>

#include <fmt/core.h>
#include <fmt/ranges.h>
#include <thrift/compiler/ast/t_function.h>
#include <thrift/compiler/ast/t_list.h>
#include <thrift/compiler/ast/t_map.h>
Expand Down

0 comments on commit 7f6edca

Please sign in to comment.