When an error occurs, log the IP address of the far end.

Summary:
Example of a current error message:
```
2024/10/11 06:21:10 thrift: error processing request: tls: first record does not look like a TLS handshake
```

It does not include any information about the connection source making it impossible to determine the source of the problem.

This patch adds the RemoteAddress() to the message to provide information about the source of the reqest that generated the error.

Reviewed By: awalterschulze

Differential Revision: D64241912

fbshipit-source-id: 70ee77ac6016f3d939e31c7d1c154f1f1ba2616f

thrift/lib/go/thrift/header_server.go

@@ -83,7 +83,7 @@ func (p *headerServer) acceptLoop(ctx context.Context) error {
 		go func(ctx context.Context, conn net.Conn) {
 			ctx = p.connContext(ctx, conn)
 			if err := p.processRequests(ctx, conn); err != nil {
-				p.log.Println("thrift: error processing request:", err)
+				p.log.Printf("error processing request from %s: %s", conn.RemoteAddr().String(), err)
 			}
 		}(ctx, conn)
 	}

thrift/lib/go/thrift/rocket_server_transport.go

@@ -107,28 +107,28 @@ func (r *rocketServerTransport) processRequests(ctx context.Context, conn net.Co
 		processor := newRocketUpgradeProcessor(r.processor)
 		headerProtocol, err := NewHeaderProtocol(conn)
 		if err != nil {
-			r.log.Println("thrift: error constructing header protocol: ", err)
+			r.log.Printf("thrift: error constructing header protocol from %s: %s", conn.RemoteAddr().String(), err)
 			return
 		}
 		if err := r.processHeaderRequest(ctx, headerProtocol, processor); err != nil {
-			r.log.Println("thrift: error processing request: ", err)
+			r.log.Printf("thrift: error processing request from %s: %s", conn.RemoteAddr().String(), err)
 			return
 		}
 		if processor.upgraded {
 			r.processRocketRequests(ctx, conn)
 		} else {
 			if err := r.processHeaderRequests(ctx, headerProtocol, processor); err != nil {
-				r.log.Println("thrift: error processing request: ", err)
+				r.log.Printf("thrift: error processing request from %s: %s", conn.RemoteAddr().String(), err)
 			}
 		}
 	case TransportIDHeader:
 		headerProtocol, err := NewHeaderProtocol(conn)
 		if err != nil {
-			r.log.Println("thrift: error constructing header protocol: ", err)
+			r.log.Printf("thrift: error constructing header protocol from %s: %s", conn.RemoteAddr().String(), err)
 			return
 		}
 		if err := r.processHeaderRequests(ctx, headerProtocol, r.processor); err != nil {
-			r.log.Println("thrift: error processing request: ", err)
+			r.log.Printf("thrift: error processing request from %s: %s", conn.RemoteAddr().String(), err)
 		}
 	}
 }