Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Darwin48v]: PM fix infoRom register offsets & update outdate bspKmods loading configs #326

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

aalamsi22
Copy link
Contributor

@aalamsi22 aalamsi22 commented Jan 30, 2025

Description

  • Fix misconfigured infoRomConfigs to use the correct register offset of 0x100.
  • Update to the latest bspKmodsRpmVersion
  • Remove bspKmodsToReload, sharedKmodsToReload, and upstreamKmodsToLoad as they are outdated configs and the loading flow is handled by the kmods.json file on the bsp and the requiredKmodsToLoad attribute.

Test

The following sw_tests passed:
async_logger_test
fan_service_sw_test
fsdb_client_test
platform_config_lib_config_lib_test
platform_data_corral_sw_test
platform_helpers_platform_name_lib_test
platform_manager_config_validator_test
platform_manager_data_store_test
platform_manager_device_path_resolver_test
platform_manager_i2c_explorer_test
platform_manager_platform_explorer_test
platform_manager_presence_checker_test
platform_manager_utils_test
rackmon_test
sensor_service_sw_test
sensor_service_utils_test
thrift_cow_visitor_tests
thrift_node_tests
weutil_crc16_ccitt_test
weutil_fboss_eeprom_parser_test

The following hw_tests passed:
data_corral_service_hw_test
sensor_service_hw_test
fan_service_hw_test
weutil_hw_test

@facebook-github-bot
Copy link
Contributor

@joancaneus has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants