Skip to content

Commit

Permalink
Fixed package 0.2.0 setup relying on older README.
Browse files Browse the repository at this point in the history
Summary:
Running `python setup.py install` or `pip install --upgrade facebookads` wasn't
working, because the package runs setup.py which expects an older version of
the README to be there.

Added a conditional check to see if the old README exists and to include that,
this way it will upgrade or install regardless of what version they're on.

Test Plan:
`pip install facebookads`
`pip install --upgrade facebookads`
  • Loading branch information
Evan Chen committed Oct 26, 2014
1 parent 9ee253e commit b4bc403
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 4 deletions.
4 changes: 3 additions & 1 deletion CHANGES.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
0.2.1
- Fixed setup.py accounting for wrong README

0.2.0
- Added ObjectStorySpec and specs module
- Moved integration tests to their own file
Expand All @@ -7,7 +10,6 @@
- Deprecated AbstractObject child method
- Renamed _read_update() to _set_data()


0.1.1
- Increase version requirement for required configparser package (Python 3 compatibility fix)
- Misc issue fix requests
Expand Down
2 changes: 1 addition & 1 deletion facebookads/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ class FacebookAdsApi(object):
this sdk.
"""

SDK_VERSION = '0.2.0'
SDK_VERSION = '0.2.1'

API_VERSION = 'v2.1'

Expand Down
9 changes: 7 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,16 @@
import os

this_dir = os.path.dirname(__file__)
readme_filename = os.path.join(this_dir, 'README.rst')
if os.path.isfile('README.rst'):
readme_filename = 'README.rst'
elif os.path.isfile('README.md'):
readme_filename = 'README.md'

readme_filename = os.path.join(this_dir, readme_filename)
requirements_filename = os.path.join(this_dir, 'requirements.txt')

PACKAGE_NAME = 'facebookads'
PACKAGE_VERSION = '0.2.0'
PACKAGE_VERSION = '0.2.1'
PACKAGE_AUTHOR = 'Facebook'
PACKAGE_AUTHOR_EMAIL = ''
PACKAGE_URL = 'https://github.com/facebook/facebook-python-ads-sdk'
Expand Down

0 comments on commit b4bc403

Please sign in to comment.