Fixes the item not found error by using filter in the product endpoint #2840
Conversation
halilozanakgul
force-pushed
the
fix_item_id_find_endpoint
branch
2 times, most recently
from
3ee78c3 to
9a31f12
Compare
| * | ||
| * @link https://developers.facebook.com/docs/marketing-api/reference/product-group/products/ | ||
| * @link https://developers.facebook.com/docs/marketing-api/reference/product-catalog/products/ | ||
| */ | ||
| class Request extends ApiRequest { |
There was a problem hiding this comment.
Few suggestions.
1/ The file is located in folder "Id", should we rename it to "Read" instead?
2/ Please update corresponding Response.php file too.
3/ This request is being called in API.php in a function called get_product_facebook_ids, let's rename it to let's say get_product_item to be more consistent with other naming in the API.php
There was a problem hiding this comment.
But this is only used to fetch the ids. I think the intent here was to make sure we can still have a separate 'read' endpoint file later if necessary. And the rest of the API calls are not consistent either.
halilozanakgul
force-pushed
the
fix_item_id_find_endpoint
branch
from
9a31f12 to
6761919
Compare
There was a problem hiding this comment.
PR checks are failing, please fix and make sure you addressed or answered to all the PR comments.
By the way, you can remove line " Do the changed files pass phpcs checks? Please remove phpcs:ignore comments in changed files and fix any issues, or delete if not practical." on your PR description.
halilozanakgul
force-pushed
the
fix_item_id_find_endpoint
branch
20 times, most recently
from
5a73515 to
df4496f
Compare
|
@halilozanakgul has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
halilozanakgul
force-pushed
the
fix_item_id_find_endpoint
branch
from
df4496f to
ea5224e
Compare
|
@halilozanakgul has updated the pull request. You must reimport the pull request before landing. |
halilozanakgul
force-pushed
the
fix_item_id_find_endpoint
branch
from
ea5224e to
eff97b4
Compare
|
@halilozanakgul has updated the pull request. You must reimport the pull request before landing. |
|
@halilozanakgul has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
halilozanakgul
force-pushed
the
fix_item_id_find_endpoint
branch
from
eff97b4 to
c13b986
Compare
|
@halilozanakgul has updated the pull request. You must reimport the pull request before landing. |
|
@halilozanakgul has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
halilozanakgul
force-pushed
the
fix_item_id_find_endpoint
branch
from
c13b986 to
c8aa287
Compare
|
@halilozanakgul has updated the pull request. You must reimport the pull request before landing. |
|
@halilozanakgul has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
halilozanakgul
force-pushed
the
fix_item_id_find_endpoint
branch
from
c8aa287 to
ea1ae29
Compare
|
@halilozanakgul has updated the pull request. You must reimport the pull request before landing. |
1 similar comment
|
@halilozanakgul has updated the pull request. You must reimport the pull request before landing. |
|
@halilozanakgul has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
halilozanakgul
force-pushed
the
fix_item_id_find_endpoint
branch
from
61d62ed to
ab3d190
Compare
|
@halilozanakgul has updated the pull request. You must reimport the pull request before landing. |
|
@halilozanakgul has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
halilozanakgul
force-pushed
the
fix_item_id_find_endpoint
branch
from
ab3d190 to
086b989
Compare
|
@halilozanakgul has updated the pull request. You must reimport the pull request before landing. |
|
@halilozanakgul has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
halilozanakgul
force-pushed
the
fix_item_id_find_endpoint
branch
from
086b989 to
e8d5798
Compare
|
@halilozanakgul has updated the pull request. You must reimport the pull request before landing. |
|
@halilozanakgul has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hi @halilozanakgul! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Changes proposed in this Pull Request:
Updates the ProductCatalog/Products/Id API call to use endpoint filter instead of directly getting the product with id.
This API call is mainly used for checking if the product item exists on Meta. When the item does not exists it threw an error. With this change the endpoint will stop erroring and will return empty list as response.
Detailed test instructions:
Changelog entry