Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Sync product set when the term name changes. #2355

Merged
merged 2 commits into from
Nov 8, 2022

Conversation

rawdreeg
Copy link
Contributor

@rawdreeg rawdreeg commented Nov 4, 2022

Changes proposed in this Pull Request:

When a product set name is modified on the site, the change isn't automatically synced to the Facebook catalog. (Changes to set titles are only pushed when new products are added to the set).

This PR allows product sets' title to be synced on update.

Closes #2344.

Replace this with a good description of your changes & reasoning.

  • [ x] Do the changed files pass phpcs checks? Please remove phpcs:ignore comments in changed files and fix any issues, or delete if not practical.

Detailed test instructions:

  1. Create a product set in Products > FB Product Sets
  2. Allow the set to sync to Facebook
  3. Edit the set name (title) in WooCommerce
  4. Notice the new name is correctly synced to the Facebook catalog

Changelog entry

Fix - Sync product set when the term name changes.

@rawdreeg rawdreeg requested a review from a team November 4, 2022 11:34
@rawdreeg rawdreeg self-assigned this Nov 4, 2022
@github-actions github-actions bot added changelog: fix Took care of something that wasn't working. type: bug The issue is a confirmed bug. labels Nov 4, 2022
Copy link
Contributor

@message-dimke message-dimke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @rawdreeg

@rawdreeg rawdreeg merged commit d617ba8 into develop Nov 8, 2022
@rawdreeg rawdreeg deleted the fix/2344-product_sets_title_not_updating branch November 8, 2022 15:14
This was referenced Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: fix Took care of something that wasn't working. type: bug The issue is a confirmed bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Product sets title updates aren't automatically synced to Facebook
2 participants