Update PHPCS config

includes/API/Catalog/Product_Group/Products/Read/Request.php

@@ -54,6 +54,4 @@ public static function get_rate_limit_id() {
 
 		return 'ads_management';
 	}
-
-
 }

includes/API/Catalog/Product_Group/Products/Read/Response.php

@@ -42,6 +42,4 @@ public function get_ids() {
 
 		return $product_item_ids;
 	}
-
-
 }

includes/API/Catalog/Product_Item/Find/Request.php

@@ -60,6 +60,4 @@ public function get_params() {
 
 		return array( 'fields' => 'id,product_group{id}' );
 	}
-
-
 }

includes/API/Catalog/Send_Item_Updates/Request.php

@@ -123,6 +123,4 @@ public function get_data() {
 			'item_type'    => 'PRODUCT_ITEM',
 		);
 	}
-
-
 }

includes/API/FBE/Configuration/Read/Response.php

@@ -18,7 +18,7 @@ class Response extends API\Response {
 	 * @return boolean
 	 */
 	public function is_ig_shopping_enabled(): bool {
-		return ! ! $this->response_data['ig_shopping']['enabled'] ?? false;
+		return (bool) $this->response_data['ig_shopping']['enabled'] ?? false;
 	}
 
 	/**
@@ -27,6 +27,6 @@ public function is_ig_shopping_enabled(): bool {
 	 * @return boolean
 	 */
 	public function is_ig_cta_enabled(): bool {
-		return ! ! $this->response_data['ig_cta']['enabled'];
+		return (bool) $this->response_data['ig_cta']['enabled'];
 	}
 }

includes/API/FBE/Configuration/Update/Request.php

@@ -52,6 +52,4 @@ public function set_plugin_version( string $plugin_version ) {
 				),
 		);
 	}
-
-
 }

includes/API/Pixel/Events/Request.php

@@ -90,6 +90,4 @@ public function get_data() {
 		 */
 		return apply_filters( 'wc_facebook_api_pixel_event_request_data', $data, $this );
 	}
-
-
 }

includes/API/Request.php

@@ -81,7 +81,7 @@ public function get_retry_count() {
 	 * @since 2.1.0
 	 */
 	public function mark_retry() {
-		$this->retry_count++;
+		++$this->retry_count;
 	}
 
 

includes/API/Traits/Idempotent_Request.php

@@ -40,6 +40,4 @@ public function get_idempotency_key() {
 
 		return $this->idempotency_key;
 	}
-
-
 }

includes/API/Traits/Rate_Limited_Response.php

@@ -118,6 +118,4 @@ public function get_rate_limit_estimated_time_to_regain_access( $headers ) {
 
 		return ! empty( $usage_data['estimated_time_to_regain_access'] ) ? (int) $usage_data['estimated_time_to_regain_access'] : null;
 	}
-
-
 }

includes/Admin/Enhanced_Catalog_Attribute_Fields.php

@@ -89,20 +89,20 @@ private function extract_attribute( &$attributes, $key ) {
 	public function render( $category_id ) {
 		$all_attributes             = $this->category_handler->get_attributes_with_fallback_to_parent_category( $category_id );
 		$all_attributes_with_values = array_map(
-			function( $attribute ) use ( $category_id ) {
+			function ( $attribute ) use ( $category_id ) {
 				return array_merge( $attribute, array( 'value' => $this->get_value( $attribute['key'], $category_id ) ) );
 			},
 			$all_attributes
 		);
 		$recommended_attributes     = array_filter(
 			$all_attributes_with_values,
-			function( $attr ) {
+			function ( $attr ) {
 				return $attr['recommended'];
 			}
 		);
 		$optional_attributes        = array_filter(
 			$all_attributes_with_values,
-			function( $attr ) {
+			function ( $attr ) {
 				return ! $attr['recommended'];
 			}
 		);
@@ -117,7 +117,7 @@ function( $attr ) {
 					$this->extract_attribute( $optional_attributes, 'size' ),
 					$this->extract_attribute( $optional_attributes, 'gender' ),
 				),
-				function( $attr ) {
+				function ( $attr ) {
 					return ! is_null( $attr );
 				}
 			);
@@ -266,7 +266,6 @@ private function render_field( $attr_id, $attribute ) {
 				// string
 				$this->render_text_field( $attr_id, $attribute, $placeholder );
 		}
-
 	}
 
 	private function render_select_field( $attr_id, $attribute ) {

includes/Admin/Notes/SettingsMoved.php

@@ -11,8 +11,8 @@
 
 defined( 'ABSPATH' ) || exit;
 
-use \Automattic\WooCommerce\Admin\Notes\Note;
-use \Automattic\WooCommerce\Admin\Notes\NoteTraits;
+use Automattic\WooCommerce\Admin\Notes\Note;
+use Automattic\WooCommerce\Admin\Notes\NoteTraits;
 
 /**
  * SettingsMoved class.

includes/Admin/Product_Categories.php

@@ -271,8 +271,8 @@ public function render_edit_enhanced_catalog_attributes_field( \WP_Term $term, $
 
 		if (
 			empty( $category_id ) ||
-			$category_handler->is_category( $category_id ) &&
-			$category_handler->is_root_category( $category_id )
+			( $category_handler->is_category( $category_id ) &&
+			$category_handler->is_root_category( $category_id ) )
 		) {
 			// show nothing
 			?>
@@ -314,8 +314,8 @@ public function render_add_enhanced_catalog_attributes_field( $category_id ) {
 
 		if (
 			empty( $category_id ) ||
-			$category_handler->is_category( $category_id ) &&
-			$category_handler->is_root_category( $category_id )
+			( $category_handler->is_category( $category_id ) &&
+			$category_handler->is_root_category( $category_id ) )
 		) {
 			// show nothing
 			return;
@@ -377,7 +377,7 @@ public function save_google_product_category_and_enhanced_attributes( $term_id,
 		$google_product_category_id = wc_clean( Helper::get_posted_value( self::FIELD_GOOGLE_PRODUCT_CATEGORY_ID ) );
 
 		\WooCommerce\Facebook\Product_Categories::update_google_product_category_id( $term_id, $google_product_category_id );
-		$this->save_enhanced_catalog_attributes( $term_id, $tt_id, $taxonomy );
+		$this->save_enhanced_catalog_attributes( $term_id );
 
 		$term = get_term( $term_id, $taxonomy );
 
@@ -423,11 +423,9 @@ public function save_google_product_category_and_enhanced_attributes( $term_id,
 	 *
 	 * @since 2.1.0
 	 *
-	 * @param int    $term_id term ID.
-	 * @param int    $tt_id term taxonomy ID.
-	 * @param string $taxonomy Taxonomy slug.
+	 * @param int $term_id term ID.
 	 */
-	public function save_enhanced_catalog_attributes( $term_id, $tt_id, $taxonomy ) {
+	public function save_enhanced_catalog_attributes( $term_id ) {
 		$enhanced_catalog_attributes = \WooCommerce\Facebook\Products::get_enhanced_catalog_attributes_from_request();
 
 		foreach ( $enhanced_catalog_attributes as $key => $value ) {

includes/Admin/Product_Sets.php

@@ -114,11 +114,11 @@ public function category_field_on_edit( $term ) {
 	 * @param int $term_id Term ID.
 	 * @param int $tt_id Term taxonomy ID.
 	 */
-	public function save_custom_field( $term_id, $tt_id ) {
+	public function save_custom_field( $term_id, $tt_id ) { // phpcs:ignore Generic.CodeAnalysis.UnusedFunctionParameter.FoundAfterLastUsed
 		$wc_product_cats = empty( $_POST[ $this->categories_field ] ) ? '' : wc_clean( wp_unslash( $_POST[ $this->categories_field ] ) ); //phpcs:ignore
 		if ( ! empty( $wc_product_cats ) ) {
 			$wc_product_cats = array_map(
-				function( $item ) {
+				function ( $item ) {
 					return absint( $item );
 				},
 				$wc_product_cats
@@ -149,7 +149,12 @@ protected function get_field_label() {
 	 */
 	protected function get_field( $term_id = '' ) {
 		$saved_items  = get_term_meta( $term_id, $this->categories_field, true );
-		$product_cats = get_terms( 'product_cat', array( 'hide_empty' => 0 ) );
+		$product_cats = get_terms(
+			array(
+				'taxonomy'   => 'product_cat',
+				'hide_empty' => false,
+			)
+		);
 		?>
 		<div class="select2 updating-message"><p></p></div>
 		<select

includes/Admin/Products.php

@@ -67,8 +67,8 @@ public static function render_enhanced_catalog_attributes_fields( $category_id,
 		);
 		if (
 			empty( $category_id ) ||
-			$category_handler->is_category( $category_id ) &&
-			$category_handler->is_root_category( $category_id )
+			( $category_handler->is_category( $category_id ) &&
+			$category_handler->is_root_category( $category_id ) )
 		) {
 			// show nothing
 			return;
@@ -170,7 +170,7 @@ private static function filter_available_product_attribute_names( \WC_Product $p
 	 */
 	public static function get_available_product_attribute_names( \WC_Product $product ) {
 		return array_map(
-			function( $attribute ) use ( $product ) {
+			function ( $attribute ) use ( $product ) {
 				return wc_attribute_label( $attribute->get_name(), $product );
 			},
 			Products_Handler::get_available_product_attributes( $product )
@@ -210,7 +210,7 @@ public static function render_commerce_fields( \WC_Product $product ) {
 		<div id="variable-product-not-ready-notice" style="display:none;">
 			<p>
 			<?php
-			echo sprintf(
+			printf(
 				/* translators: Placeholders %1$s - strong opening tag, %2$s - strong closing tag */
 				esc_html__( 'To sell this product on Instagram, at least one variation must be synced to Facebook. You can control variation sync on the %1$sVariations%2$s tab with the %1$sFacebook Sync%2$s setting.', 'facebook-for-woocommerce' ),
 				'<strong>',

includes/Admin/Settings.php

@@ -177,7 +177,9 @@ private function connect_to_enhanced_admin( $screen_id ) {
 			$crumbs = array(
 				__( 'Facebook for WooCommerce', 'facebook-for-woocommerce' ),
 			);
+			//phpcs:ignore WordPress.Security.NonceVerification.Recommended
 			if ( ! empty( $_GET['tab'] ) ) {
+				//phpcs:ignore WordPress.Security.NonceVerification.Recommended
 				switch ( $_GET['tab'] ) {
 					case Connection::ID:
 						$crumbs[] = __( 'Connection', 'facebook-for-woocommerce' );
@@ -302,7 +304,7 @@ public function get_screens() {
 		// ensure no bogus values are added via filter
 		$screens = array_filter(
 			$screens,
-			function( $value ) {
+			function ( $value ) {
 				return $value instanceof Abstract_Settings_Screen;
 			}
 		);
@@ -362,7 +364,7 @@ private function register_woo_nav_menu_items() {
 					'order'  => $order,
 				)
 			);
-			$order++;
+			++$order;
 		}
 	}
 }

includes/ExternalVersionUpdate/Update.php

@@ -101,5 +101,4 @@ public function send_new_version_to_facebook_server() {
 			return false;
 		}
 	}
-
 }

includes/Framework/Api/Base.php

@@ -680,6 +680,7 @@ public function set_tls_1_2_request( $handle, $r, $url ) {
 		if ( ! Helper::str_starts_with( $url, 'https://' ) ) {
 			return;
 		}
+		//phpcs:ignore: WordPress.WP.AlternativeFunctions.curl_curl_setopt
 		curl_setopt( $handle, CURLOPT_SSLVERSION, 6 );
 	}
 

includes/Framework/Api/Response.php

@@ -30,5 +30,4 @@ public function to_string();
 	 * @return string the request, safe for logging/displaying
 	 */
 	public function to_string_safe();
-
 }

includes/Framework/Utilities/BackgroundJobHandler.php

@@ -656,8 +656,8 @@ public function process_job( $job, $items_per_batch = null ) {
 				// process the item
 				$this->process_item( $item, $job );
 
-				$processed++;
-				$job->progress++;
+				++$processed;
+				++$job->progress;
 
 				// update job progress
 				$job = $this->update_job( $job );

includes/Jobs/CleanupSkyvergeFrameworkJobOptions.php

@@ -57,5 +57,4 @@ public function clean_up_old_completed_options() {
 			LIMIT 500"
 		);
 	}
-
 }

includes/Jobs/DeleteProductsFromFBCatalog.php

@@ -16,7 +16,8 @@
  */
 class DeleteProductsFromFBCatalog extends AbstractChainedJob {
 
-	use BatchQueryOffset, LoggingTrait;
+	use BatchQueryOffset;
+	use LoggingTrait;
 
 	/**
 	 * Called before starting the job.
@@ -57,7 +58,6 @@ protected function get_items_for_batch( int $batch_number, array $args ): array
 		);
 
 		return array_map( 'intval', $products );
-
 	}
 
 	/**
@@ -125,5 +125,4 @@ public function get_plugin_name(): string {
 	public function get_batch_size(): int {
 		return 25;
 	}
-
 }

includes/Jobs/ResetAllProductsFBSettings.php

@@ -16,7 +16,8 @@
  */
 class ResetAllProductsFBSettings extends AbstractChainedJob {
 
-	use BatchQueryOffset, LoggingTrait;
+	use BatchQueryOffset;
+	use LoggingTrait;
 
 	/**
 	 * Called before starting the job.
@@ -57,7 +58,6 @@ protected function get_items_for_batch( int $batch_number, array $args ): array
 		);
 
 		return array_map( 'intval', $products );
-
 	}
 
 	/**
@@ -116,5 +116,4 @@ public function get_plugin_name(): string {
 	public function get_batch_size(): int {
 		return 25;
 	}
-
 }

includes/ProductSync/ProductValidator.php

@@ -347,10 +347,8 @@ protected function validate_product_sync_field() {
 
 			// Variable product has no variations with sync enabled so it shouldn't be synced.
 			throw $invalid_exception;
-		} else {
-			if ( 'no' === $this->product->get_meta( self::SYNC_ENABLED_META_KEY ) ) {
+		} elseif ( 'no' === $this->product->get_meta( self::SYNC_ENABLED_META_KEY ) ) {
 				throw $invalid_exception;
-			}
 		}
 	}
 
@@ -443,5 +441,4 @@ protected function validate_variation_structure() {
 			throw new ProductInvalidException( __( 'Too many attributes selected for product. Use 4 or less.', 'facebook-for-woocommerce' ) );
 		}
 	}
-
 }

includes/Products/Sync/Background.php

@@ -118,8 +118,8 @@ public function process_items( $job, $data, $items_per_batch = null ) {
 				facebook_for_woocommerce()->log( "Background sync error: {$e->getMessage()}" );
 			}
 
-			$processed++;
-			$job->progress++;
+			++$processed;
+			++$job->progress;
 			// update job progress
 			$job = $this->update_job( $job );
 			// job limits reached