-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(blog): apply trailing slash to blog feed #9920
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Size Change: 0 B Total Size: 992 kB ℹ️ View Unchanged
|
Found a todo docusaurus/packages/docusaurus-utils-common/src/applyTrailingSlash.ts Lines 27 to 30 in d7a7cae
I think we can do it in this PR however should we keep the one in utils-common or utils ?
|
This code is env agnostic so it should rather be in utils-common, but is not because this shared package was introduced later. I'd prefer if you did this refactor in another PR because this will impact various files unrelated to this feature. |
Thank you! |
Co-authored-by: sebastien <lorber.sebastien@gmail.com>
Pre-flight checklist
Motivation
tools like Algolia that use the feed files may behave unusual if trailing slash is enabled and not applied to links
Test Plan
feed.test.ts
=>has feed item for each post trailing slash
Deploy preview ??
Test links
rss.xml
Related issues/PRs
Fix #9829