Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remark-npm2yarn): update npm-to-yarn from 2.0.0 to 2.2.1, fix pnpm extra args syntax #9861

Merged
merged 2 commits into from
Feb 17, 2024

Conversation

OzakIOne
Copy link
Contributor

@OzakIOne OzakIOne commented Feb 17, 2024

Pre-flight checklist

Motivation

As discussed in #9761 there is an error when converting npm commands with -- syntax to pnpm, pnpm doesn't support this syntax

Updating to version 2.2.1 fixes this issue by removing -- in the converted command

Test Plan

Deploy preview

Test links

Deploy preview: https://deploy-preview-9861--docusaurus-2.netlify.app/docs/typescript-support#swizzling-typescript-theme-components

Related issues/PRs

#9761

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 17, 2024
Copy link

netlify bot commented Feb 17, 2024

[V2]

Name Link
🔨 Latest commit a441e49
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/65d11d139269e60008b9507a
😎 Deploy Preview https://deploy-preview-9861--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Feb 17, 2024

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 88 🟢 98 🟢 96 🟢 100 🟠 88 Report
/docs/installation 🟠 89 🟢 96 🟢 100 🟢 100 🟠 88 Report
/docs/category/getting-started 🟠 76 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog 🟠 70 🟢 100 🟢 100 🟢 90 🟠 88 Report
/blog/preparing-your-site-for-docusaurus-v3 🟠 65 🟢 96 🟢 100 🟢 100 🟠 88 Report
/blog/tags/release 🟠 70 🟢 100 🟢 100 🟠 80 🟠 88 Report
/blog/tags 🟠 77 🟢 100 🟢 100 🟢 90 🟠 88 Report

Copy link

github-actions bot commented Feb 17, 2024

Size Change: 0 B

Total Size: 992 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 75.4 kB
website/build/assets/css/styles.********.css 114 kB
website/build/assets/js/main.********.js 765 kB
website/build/index.html 37.9 kB

compressed-size-action

@Josh-Cena Josh-Cena merged commit 1bbc68b into main Feb 17, 2024
31 checks passed
@Josh-Cena Josh-Cena deleted the ozaki/npmtoyarn branch February 17, 2024 21:36
@Josh-Cena
Copy link
Collaborator

I'm not sure if anything's wrong but the deploy preview doesn't show any output change...

image

@OzakIOne
Copy link
Contributor Author

Yes same thing on my end but building locally does fix the issue weird...

@Josh-Cena
Copy link
Collaborator

Could be because Netlify caches the dependencies. As long as the package actually delivers a fix, users will be able to update without us making any change, so we don't really have to worry about it.

@slorber
Copy link
Collaborator

slorber commented Feb 18, 2024

Yes maybe a cache issue 🤔

Issue fixed on prod website:
https://docusaurus.io/docs/swizzling#ejecting

Thanks 👍

going to consider it as a bugfix and backport in, just in case some users are affected by it

@slorber slorber changed the title chore(deps): update npm to yarn from 2.0.0 to 2.2.1 fix(remark-npm2yarn): update npm-to-yarn from 2.0.0 to 2.2.1, fix pnpm extra args syntax Feb 18, 2024
@slorber slorber added pr: bug fix This PR fixes a bug in a past release. to backport This PR is planned to be backported to a stable version of Docusaurus labels Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release. to backport This PR is planned to be backported to a stable version of Docusaurus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants