-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(remark-npm2yarn): update npm-to-yarn from 2.0.0 to 2.2.1, fix pnpm extra args syntax #9861
Conversation
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Size Change: 0 B Total Size: 992 kB ℹ️ View Unchanged
|
Yes same thing on my end but building locally does fix the issue weird... |
Could be because Netlify caches the dependencies. As long as the package actually delivers a fix, users will be able to update without us making any change, so we don't really have to worry about it. |
Yes maybe a cache issue 🤔 Issue fixed on prod website: Thanks 👍 going to consider it as a bugfix and backport in, just in case some users are affected by it |
Pre-flight checklist
Motivation
As discussed in #9761 there is an error when converting npm commands with
--
syntax to pnpm, pnpm doesn't support this syntaxUpdating to version 2.2.1 fixes this issue by removing
--
in the converted commandTest Plan
Deploy preview
Test links
Deploy preview: https://deploy-preview-9861--docusaurus-2.netlify.app/docs/typescript-support#swizzling-typescript-theme-components
Related issues/PRs
#9761