feat(theme): add support for meta og locale and alternates #9152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlorinaPacurar
requested review from
slorber,
lex111 and
Josh-Cena
as code owners
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Hello, #8894 already exists. Thank you for your interest but please check existing PRs first. |
3 tasks
slorber
requested changes
Jul 27, 2023
There was a problem hiding this comment.
Thanks, almost looks good.
This should rather be handled in theme/SiteMetadata (theme) instead of SiteMetadataDefaults because supporting og locale attributes is opinionated, shouldn't be mandatory for users and we should give them the ability to remove support if they don't want it (which would reduce the size of the html pages).
See location of original PR here: #8894
|
Thanks @slorber - updated. |
slorber
requested changes
Jul 28, 2023
packages/docusaurus-theme-classic/src/theme/SiteMetadata/index.tsx
Outdated
Show resolved
Hide resolved
packages/docusaurus-theme-classic/src/theme/SiteMetadata/index.tsx
Outdated
Show resolved
Hide resolved
packages/docusaurus-theme-classic/src/theme/SiteMetadata/index.tsx
Outdated
Show resolved
Hide resolved
slorber
changed the title
slorber
pushed a commit
to VinceCYLiao/docusaurus
that referenced
this pull request
Aug 3, 2023
This was referenced Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
Motivation
Fix #8887 by adding og locale and alternates
Test Plan
Tested locally in browser with suggested config
Test links
Deploy preview: https://deploy-preview-9152--docusaurus-2.netlify.app/
Related issues/PRs
issue #8887