Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: backport retro compatible commits for the Docusaurus v2.4.1 release #8979

Merged
merged 11 commits into from
May 15, 2023
Merged

chore: backport retro compatible commits for the Docusaurus v2.4.1 release #8979

merged 11 commits into from
May 15, 2023

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented May 15, 2023

Motivation

chore: backport retro compatible commits for the Docusaurus v2.4.1 release

Deploy preview: https://deploy-preview-8979--docusaurus-2.netlify.app/

All v2.4.1 links:

sachin-nanayakkara and others added 10 commits May 15, 2023 14:48
@sachin-nanayakkara @slorber
fix(create): add missing await (#8831)
b6d5262
@tarunrajput @dotslashtarun @slorber
fix(theme-translations): remove redundant navigation text in aria lab…
74781b0 
…el (#8842)

Co-authored-by: Tarun Chauhan <tarun.chauhan@tripjack.com>
@armano2 @slorber
refactor(theme): expose copy, success and word-wrap icons as standalo…
d20e9c4 
…ne components (#8862)
@morsko1 @slorber
fix(utils): handle Markdown links with spaces to route correctly (#8874)
6fae23b
@slorber
fix(theme-common): fix confusing theme error message: bad sidebar id …
aa49226 
…suggestions (#8873)
@slorber
fix(theme-common): fix collapsible component with prefers-reduced-mot…
8346c23 
…ion (#8906)
@slorber
fix(theme): add __ prefix to technical anchors, search crawlers (Algo…
b345e9b 
…lia) should ignore them (#8909)
@andrewnicols @slorber
fix(core): Correct yarn upgrade command for yarn 2.x (#8908)
704841f 
Co-authored-by: sebastienlorber <lorber.sebastien@gmail.com>
@LiberaTeMetuMortis @slorber
fix(theme-translations): fix Turkish translation for aria label "Ente…
2a16f63 
…r key" (#8933)
@slorber
fix(theme): fix collapsible sidebar behavior when prefers-reduced-mot…
941f717 
…ion (#8971)
@slorber slorber added the pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog. label May 15, 2023
@slorber slorber requested review from lex111 and Josh-Cena as code owners May 15, 2023 13:11
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 15, 2023
@slorber slorber mentioned this pull request May 15, 2023
Merged
@netlify
Copy link

netlify bot commented May 15, 2023 •
edited
Loading

✅ [V2]

Name Link
🔨 Latest commit 60e657d
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/646232aa8dd744000800b30d
😎 Deploy Preview https://deploy-preview-8979--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented May 15, 2023 •
edited
Loading

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 85 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 79 🟢 100 🟢 100 🟢 100 🟢 90 Report

@github-actions
Copy link

Size Change: +137 B (0%)

Total Size: 818 kB

Filename Size Change
website/build/assets/js/main.********.js 618 kB +121 B (0%)
ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 53.8 kB 0 B
website/build/assets/css/styles.********.css 107 kB +2 B (0%)
website/build/index.html 39.3 kB +14 B (0%)

compressed-size-action

@slorber slorber mentioned this pull request May 15, 2023
Merged
@slorber slorber merged commit 4a2200a into docusaurus-v2 May 15, 2023
@slorber slorber deleted the slorber/docusaurus-v2.4.1-backport branch May 15, 2023 13:41
Khlooddeeb
Khlooddeeb reviewed Aug 5, 2023
View reviewed changes
Copy link

@Khlooddeeb Khlooddeeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@slorber slorber mentioned this pull request Sep 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Khlooddeeb Khlooddeeb Khlooddeeb left review comments

@lex111 lex111 Awaiting requested review from lex111

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena Josh-Cena is a code owner

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA pr: internal This PR does not touch production code, or is not meaningful enough to be in the changelog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@slorber @Khlooddeeb @facebook-github-bot @sachin-nanayakkara @tarunrajput @armano2 @morsko1 @andrewnicols @LiberaTeMetuMortis